Enhance liveness probes for manila-operator #49
Conversation
silvacarloss
force-pushed
the
enhance-probes
branch
2 times, most recently
from
3bef483 to
90275d7
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
3 times, most recently
from
ab8bf90 to
2b919ce
Compare
|
/test manila-operator-build-deploy-tempest |
|
/test manila-operator-build-deploy-tempest think we need to harden the ceph deployment a bit |
|
@silvacarloss - can you please rebase this change: |
silvacarloss
force-pushed
the
enhance-probes
branch
from
2b919ce to
e84e652
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
3 times, most recently
from
12f8127 to
549fd85
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
2 times, most recently
from
a113688 to
7fbe449
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
from
7fbe449 to
f92f022
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
from
f92f022 to
6876f2a
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
from
6876f2a to
723f3e7
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
4 times, most recently
from
f1de144 to
2b71578
Compare
silvacarloss
force-pushed
the
enhance-probes
branch
3 times, most recently
from
dda7261 to
c44cbe0
Compare
|
/retest |
|
The kuttl job isn't logging to stdout, and all debug messages are being picked up when we do manila-manage service list. That made me add a workaround to remove the DEBUG info from the manila-manage command output, and I think it could still be relevant, considering that we must treat it in case a customer wants to enable debugging and we don't want the code to break. |
There was a problem hiding this comment.
Thanks @silvacarloss ; this looks good.. some minor comments inline.
Manila-operator is currently doing limited actions when it comes to doing healthchecks. This change enhances the probes so we can do actual checks on the status of the manila services, by implementing a simple HTTP server (as being done by the cinder operator) The HTTP server though will do the healthchecks using a command we offer in Manila: manila-manage service list. The HTTP server will take as arguments the type of service you are trying to ensure is alive (share or scheduler) and the location of the manila configuration file. Manila-manage service list command does not require any kind of additional client to be run, nor keystone tokens or additional authentication steps are required. The command will simply get the services that are already registered in the database. Then, the HTTP server will check on the state of the services and respond to the operator according to the state and filters matching.
silvacarloss
force-pushed
the
enhance-probes
branch
from
c44cbe0 to
26b2a35
Compare
|
/retest |
| # configuration directory (defaults to /etc/manila/manila.conf.d) | ||
|
|
||
| from http import server | ||
| import logging |
There was a problem hiding this comment.
Thanks @silvacarloss
a minor comment inline; you can drop the unused import in a follow up patch
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouthampacha, silvacarloss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5e9945a
into
openstack-k8s-operators:main
Follow-up for pull request #49 (healthchecks)
The manila operator needs to do checks on services status to ensure they are actually up. This change enhances the liveness probes for the manila-share and manila-scheduler services by implementing a HTTP probe using a custom HTTP server. The HTTP server will take advantage of the
manila-manage service listcommand, which is an interface manila provides to get the services that are current registered in the database, then allowing the probe to check the services actual state.