-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change weight assigned to podAntiAffinity to 100 #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The affinity weight ca be between 1 and 100 for each instance of the preferredDuringSchedulingIgnoredDuringExecution affinity type. When the scheduler finds nodes that meet all the other scheduling requirements of the Pod, the scheduler iterates through every preferred rule that the node satisfies and adds the value of the weight for that expression to a sum. To make the pods better spread bump the weight to the max. Still the anti affinty is "this Pod should not run in an X if that X is already running one or more Pods that meet rule Y", which means if there are less nodes, but enough resources, the pods get scheduled there. Related: https://issues.redhat.com/browse/OSPRH-8870
abays
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
stuggi
added a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/cinder-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/horizon-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/keystone-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/neutron-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/octavia-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to openstack-k8s-operators/ovn-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Jul 30, 2024
openstack-k8s-operators/lib-common#542 Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The affinity weight ca be between 1 and 100 for each instance of the preferredDuringSchedulingIgnoredDuringExecution affinity type. When the scheduler finds nodes that meet all the other scheduling requirements of the Pod, the scheduler iterates through every preferred rule that the node satisfies and adds the value of the weight for that expression to a sum.
To make the pods better spread bump the weight to the max. Still the anti affinty is "this Pod should not run in an X if that X is already running one or more Pods that meet rule Y", which means if there are less nodes, but enough resources, the pods get scheduled there.
Related: https://issues.redhat.com/browse/OSPRH-8870