Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint #374

Merged

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Feb 16, 2024

Bump the golangci-lint version to the newest that still supports 1.20 and removed disabled checks that passing now.

Bump the golangci-lint version to the newest that still supports 1.20
and removed disabled checks that passing now.
@abays
Copy link
Contributor

abays commented Feb 16, 2024

/test keystone-operator-build-deploy-kuttl

Unable to establish connection to https://keystone-public-openstack.apps.oko-02.oooci.ccitredhat.com/v3/auth/tokens: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays
Copy link
Contributor

abays commented Feb 19, 2024

KUTTL tests need adjustment for new dependencies:

case.go:366: resource Pod:keystone-kuttl-tests/: .metadata.annotations.openshift.io/scc: value mismatch, expected: anyuid != actual: restricted-v2

@abays
Copy link
Contributor

abays commented Feb 20, 2024

KUTTL tests need adjustment for new dependencies:

case.go:366: resource Pod:keystone-kuttl-tests/: .metadata.annotations.openshift.io/scc: value mismatch, expected: anyuid != actual: restricted-v2

I can't reproduce this locally. Trying again in CI.

/test keystone-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 2dc967b into openstack-k8s-operators:main Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants