[tlse] TLS database connection #402
Conversation
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b7cc43ceb31f4bc29c483d5264e3b1df ❌ openstack-k8s-operators-content-provider FAILURE in 7m 41s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/76d0eae8ebfd48f59e1fdd174dacf59e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 23s |
stuggi
force-pushed
the
tls_db
branch
2 times, most recently
from
65a577c to
4af63b8
Compare
| @@ -647,11 +648,22 @@ func (r *IronicNeutronAgentReconciler) generateServiceConfigMaps( | |||
|
|
|||
| cmLabels := labels.GetLabels(instance, labels.GetGroupLabel(ironic.ServiceName), map[string]string{}) | |||
|
|
|||
| db, err := mariadbv1.GetDatabaseByName(ctx, h, ironic.DatabaseName) | |||
There was a problem hiding this comment.
@hjensas do the neutronagent even need/has access to the db?
There was a problem hiding this comment.
No direct DB access in the agent.
There was a problem hiding this comment.
ack, thanks. I have reverted the change to the agent. please have a look when you get to it. right now there is an issue in ci.
|
/retest |
|
/test ironic-operator-build-deploy-kuttl |
The my.cnf file gets added to the secret holding the service configs. The content of my.cnf is centrally managed in the mariadb-operator and retrieved calling db.GetDatabaseClientConfig(tlsCfg) Depends-On: openstack-k8s-operators/mariadb-operator#190 Depends-On: openstack-k8s-operators/mariadb-operator#191 Jira: OSPRH-4547
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c793741
into
openstack-k8s-operators:main
| @@ -86,7 +86,7 @@ function common_ironic_config { | |||
| crudini --set ${SVC_CFG_MERGED} DEFAULT transport_url $TRANSPORTURL | |||
| crudini --set ${SVC_CFG_MERGED} DEFAULT rpc_transport oslo | |||
| fi | |||
| crudini --set ${SVC_CFG_MERGED} database connection mysql+pymysql://${DBUSER}:${DBPASSWORD}@${DBHOST}/${DB} | |||
| crudini --set ${SVC_CFG_MERGED} database connection mysql+pymysql://${DBUSER}:${DBPASSWORD}@${DBHOST}/${DB}?read_default_file=/etc/my.cnf | |||
There was a problem hiding this comment.
this needed to be added in ironicinspector/bin/init.sh also, and the TLS volume mounts added to ironicinspector/dbsync.go . ill fix this in my mariadbaccount patch
The my.cnf file gets added to the secret holding the service configs. The content of my.cnf is centrally managed in the mariadb-operator and retrieved calling db.GetDatabaseClientConfig(tlsCfg)
Depends-On: openstack-k8s-operators/mariadb-operator#190
Depends-On: openstack-k8s-operators/mariadb-operator#191
Jira: OSPRH-4547