openstack_wait: call 'make openstack' dynamically #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprince
force-pushed
the
openstack_wait_dynamic
branch
from
06608d7 to
e4272dd
Compare
In some cases CI might end up calling 'make openstack' multiple times when using openstack_wait. This updates the Makefile dependency here to be dynamic and only call 'make openstack' if a subscription isn't found for the operator.
dprince
force-pushed
the
openstack_wait_dynamic
branch
from
e4272dd to
f75cf66
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 36bd1b9
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases CI might end up calling 'make openstack' multiple times when using openstack_wait. This updates the Makefile dependency here to be dynamic and only call 'make openstack' if a subscription isn't found for the operator.