Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openstack_deploy_cleanup from openstack_init target #974

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Dec 12, 2024

This causes CI to fail when running init on a clean environment

@openshift-ci openshift-ci bot requested review from fao89 and olliewalsh December 12, 2024 14:54
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This causes CI to fail when running init on a clean environment

Now we just checkout the openstack-operator repo if it doesn't
already exist
@dprince dprince force-pushed the drop_cleanup_from_init branch from b3958c2 to a386a1d Compare December 12, 2024 15:03
@openshift-ci openshift-ci bot removed the lgtm label Dec 12, 2024
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

New changes are detected. LGTM label has been removed.

@abays abays added the lgtm label Dec 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4effac1 into openstack-k8s-operators:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants