Restoring expansion in interface scripts #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Podivin <[email protected]>
jpodivin
force-pushed
the
expansionrestoration
branch
from
51d10e7 to
c2c7c95
Compare
fao89
approved these changes
Dec 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5a4d9bc
into
openstack-k8s-operators:main
5 checks passed
bogdando
reviewed
Dec 9, 2024
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
| # set -x | |||
| set -x | |||
There was a problem hiding this comment.
creds and KUBEADMIN_PWD should not be echoed
however, this is a nit as we do not use real passwords in dev setups, and those scripts should never be used outside of devsetups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's generally better to see scripts expanded. Both scripts were committed with the option commented out, I assume this was an oversight.