Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octavia services depend on nova and neutron #742

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Octavia services depend on nova and neutron #742

merged 1 commit into from
Mar 12, 2024

Conversation

beagles
Copy link
Contributor

@beagles beagles commented Feb 22, 2024

The operator is needs nova and neutron to deploy the amphora controller services.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@beagles
Copy link
Contributor Author

beagles commented Feb 22, 2024

/test all

@beagles beagles marked this pull request as ready for review March 4, 2024 13:25
@openshift-ci openshift-ci bot requested review from karelyatin and stuggi March 4, 2024 13:25
beagles added a commit to beagles/octavia-operator that referenced this pull request Mar 4, 2024
@beagles
Test patch to exercise install_yamls PR
63022d5 
Depends-On: openstack-k8s-operators/install_yamls#742
@beagles beagles mentioned this pull request Mar 4, 2024
Closed
@beagles beagles marked this pull request as draft March 4, 2024 18:31
@beagles beagles force-pushed the fix-octavia-kuttl branch 2 times, most recently from e5b6a0b to 07bc590 Compare March 5, 2024 17:55
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1c62eed644ee440280537cb763bbbd58

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 22s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 10m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 36s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 07m 44s

@beagles beagles force-pushed the fix-octavia-kuttl branch from 07bc590 to 7ca8130 Compare March 6, 2024 13:27
@beagles beagles marked this pull request as ready for review March 6, 2024 13:28
@openshift-ci openshift-ci bot requested a review from cjeanner March 6, 2024 13:28
@weinimo weinimo mentioned this pull request Mar 6, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/743e8603f6694f4a9b86d401f2dbf143

❌ openstack-k8s-operators-content-provider FAILURE in 9m 13s
⚠️ install-yamls-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@beagles
Copy link
Contributor Author

beagles commented Mar 6, 2024

recheck

@beagles beagles force-pushed the fix-octavia-kuttl branch from 7ca8130 to 4f1fd13 Compare March 6, 2024 15:40
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3f6843893c054f838736869e8a441b1b

✔️ openstack-k8s-operators-content-provider SUCCESS in 19m 45s
❌ install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 5s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 4s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 3s

@weinimo
Copy link
Contributor

weinimo commented Mar 7, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e317e70f539748a3b20b44563775289c

✔️ openstack-k8s-operators-content-provider SUCCESS in 52m 50s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 20m 39s
❌ podified-multinode-edpm-deployment-crc FAILURE in 22m 19s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 26m 27s

@weinimo weinimo mentioned this pull request Mar 12, 2024
Closed
@beagles beagles force-pushed the fix-octavia-kuttl branch from 4f1fd13 to e4c74f7 Compare March 12, 2024 10:30
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/install_yamls for 742,e4c74f75a358c629b087f8783dbfa77bed915c6c

@beagles beagles force-pushed the fix-octavia-kuttl branch from e4c74f7 to 227eead Compare March 12, 2024 10:43
@weinimo
Copy link
Contributor

weinimo commented Mar 12, 2024

lgtm

abays
abays reviewed Mar 12, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@beagles
Octavia services depend on nova, neutron and glance
d52e930 
The operator is needs a few core openstack services to deploy the
amphora controller services.
@beagles beagles force-pushed the fix-octavia-kuttl branch from 227eead to d52e930 Compare March 12, 2024 15:51
abays
abays approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested locally with workarounds for missing upstream image SHAs (which are not related to the changes in this PR)

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, beagles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bfd6558 into openstack-k8s-operators:main Mar 12, 2024
5 checks passed
Deydra71 added a commit to Deydra71/install_yamls that referenced this pull request Mar 15, 2024
@Deydra71
Octavia services depend on placement
f0d0702 
As nova has been added to the dependency list in openstack-k8s-operators#742, placement must be add as well for nova to be succesfully deployed.

Signed-off-by: Veronika Fisarova <[email protected]>
@Deydra71 Deydra71 mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinimo weinimo weinimo left review comments

@abays abays abays approved these changes

@karelyatin karelyatin Awaiting requested review from karelyatin

@stuggi stuggi Awaiting requested review from stuggi

@cjeanner cjeanner Awaiting requested review from cjeanner

Assignees

@abays abays

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beagles @weinimo @abays @openshift-merge-robot