Skip to content

Commit

Permalink
Make IMAGE optional for service deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
kajinamit committed Apr 20, 2023
1 parent 9e98e1a commit c031e00
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
8 changes: 0 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ openstack_cleanup: ## deletes the operator, but does not cleanup the service res

.PHONY: openstack_deploy_prep
openstack_deploy_prep: export KIND=OpenStackControlPlane
openstack_deploy_prep: export IMAGE=unused
openstack_deploy_prep: openstack_deploy_cleanup $(if $(findstring true,$(NETWORK_ISOLATION)), nmstate nncp netattach metallb metallb_config) ## prepares the CR to install the service based on the service sample file OPENSTACK
$(eval $(call vars,$@,openstack))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -635,7 +634,6 @@ ovn_cleanup: ## deletes the operator, but does not cleanup the service resources

.PHONY: ovn_deploy_prep
ovn_deploy_prep: export KIND=.*
ovn_deploy_prep: export IMAGE=unused
ovn_deploy_prep: ovn_deploy_cleanup ## prepares the CR to install the service based on the service sample file OVNAPI
$(eval $(call vars,$@,ovn))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -674,7 +672,6 @@ ovs_cleanup: ## deletes the operator, but does not cleanup the service resources

.PHONY: ovs_deploy_prep
ovs_deploy_prep: export KIND=.*
ovs_deploy_prep: export IMAGE=unused
ovs_deploy_prep: ovs_deploy_cleanup ## prepares the CR to install the service based on the service sample file OVS
$(eval $(call vars,$@,ovs))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -753,7 +750,6 @@ cinder_cleanup: ## deletes the operator, but does not cleanup the service resour

.PHONY: cinder_deploy_prep
cinder_deploy_prep: export KIND=Cinder
cinder_deploy_prep: export IMAGE=unused
cinder_deploy_prep: cinder_deploy_cleanup ## prepares the CR to install the service based on the service sample file CINDER
$(eval $(call vars,$@,cinder))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -877,7 +873,6 @@ octavia_cleanup: ## deletes the operator, but does not cleanup the service resou

.PHONY: octavia_deploy_prep
octavia_deploy_prep: export KIND=Octavia
octavia_deploy_prep: export IMAGE=unused
octavia_deploy_prep: octavia_deploy_cleanup ## prepares the CR to install the service based on the service sample file OCTAVIA
$(eval $(call vars,$@,octavia))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -925,7 +920,6 @@ nova_deploy_prep: export KIND=Nova
# but for projects like Cinder and Nova where there are multiple services with
# different images this customization does not make sense. Make this
# customization optional in the tooling.
nova_deploy_prep: export IMAGE=unused
nova_deploy_prep: nova_deploy_cleanup ## prepares the CR to install the service based on the service sample file NOVA
$(eval $(call vars,$@,nova))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down Expand Up @@ -1162,7 +1156,6 @@ heat_deploy_prep: heat_deploy_cleanup ## prepares the CR to install the service
bash scripts/gen-service-kustomize.sh

.PHONY: heat_deploy
heat_deploy: export IMAGE=unused
heat_deploy: input heat_deploy_prep ## installs the service instance using kustomize. Runs prep step in advance. Set HEAT_REPO and HEAT_BRANCH to deploy from a custom repo.
$(eval $(call vars,$@,heat))
bash scripts/operator-deploy-resources.sh
Expand Down Expand Up @@ -1357,7 +1350,6 @@ manila_cleanup: ## deletes the operator, but does not cleanup the service resour

.PHONY: manila_deploy_prep
manila_deploy_prep: export KIND=Manila
manila_deploy_prep: export IMAGE=unused
manila_deploy_prep: manila_deploy_cleanup ## prepares the CR to install the service based on the service sample file MANILA
$(eval $(call vars,$@,manila))
mkdir -p ${OPERATOR_BASE_DIR} ${OPERATOR_DIR} ${DEPLOY_DIR}
Expand Down
4 changes: 1 addition & 3 deletions scripts/gen-service-kustomize.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ if [ -z "$DEPLOY_DIR" ]; then
echo "Please set DEPLOY_DIR"; exit 1
fi

if [ -z "$IMAGE" ]; then
echo "Please set IMAGE"; exit 1
fi
IMAGE=${IMAGE:-unused}
IMAGE_PATH=${IMAGE_PATH:-containerImage}

NAME=${KIND,,}
Expand Down

0 comments on commit c031e00

Please sign in to comment.