Restrict ALLOWED_HOSTS #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshephar
force-pushed
the
no-allowed-hosts-all
branch
2 times, most recently
from
e2637c2 to
a30fa31
Compare
bshephar
force-pushed
the
no-allowed-hosts-all
branch
from
7b1a147 to
06906f4
Compare
bshephar
force-pushed
the
no-allowed-hosts-all
branch
2 times, most recently
from
eac45a3 to
aef172e
Compare
This change removes the ALLOWED_HOSTS=* and restricts it instead to the Route Host and also the IP address of the pod. To determine the IP address of the pod, this PR adds a function that will retrieve the pods primary interface IP address and insert it into the ALLOED_HOSTS list. This will facilitate liveness checks against each of the pods. Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
no-allowed-hosts-all
branch
from
aef172e to
37cb430
Compare
deshipu
approved these changes
Mar 27, 2024
|
@deshipu: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, bshephar, deshipu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7b8ae01
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
ALLOWED_HOSTS=*and restricts itinstead to the service Endpoint of the Horizon service