Remove enabled_backend entry from 00-config.conf #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test precommit-check |
|
/test glance-operator-build-deploy-tempest |
fmount
force-pushed
the
cleanup_template
branch
from
0da9d74 to
c8d740b
Compare
konan-abhi
approved these changes
Feb 8, 2024
|
/test glance-operator-build-deploy-kuttl |
1 similar comment
|
/test glance-operator-build-deploy-kuttl |
fmount
commented
Feb 12, 2024
fmount
force-pushed
the
cleanup_template
branch
from
c8d740b to
2e22c55
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fmount
force-pushed
the
cleanup_template
branch
from
2e22c55 to
b179e61
Compare
|
New changes are detected. LGTM label has been removed. |
fmount
force-pushed
the
cleanup_template
branch
from
b179e61 to
17b979f
Compare
|
/retest |
fmount
force-pushed
the
cleanup_template
branch
2 times, most recently
from
0123eb1 to
12b786a
Compare
With webhooks we prevent the glance deploy unless a backend is specified via customServiceConfig. It doesn't fail if replicas is set to 0, but in general a backend must be specified. Signed-off-by: Francesco Pantano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
webhookswe prevent theGlancedeploy unless a backend is specified viacustomServiceConfig.It doesn't fail if
replicasis set to0, but in general a backend must be specified.This patch reinforce what already done by removing the
enabled_backendsinformation from00-config.Depends-On: openstack-k8s-operators/openstack-operator#1130