Expose DBPurge Age and Schedule #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
requested review from
abays and
konan-abhi
and removed request for
dprince and
olliewalsh
|
@ASBishop FYI: I have a WIP patch that will be rebased on top of this to simplify the cronJob handling in the operator for image-cache, but I wanted to share this change w/ you as it's supposed to align Glance and the API/interface with what we've done in cinder/manila. |
abays
reviewed
Feb 5, 2024
This patch updates the current glance CR to expose both dbPurgeAge and dbPurgeSchedule as customizable parameters. They were previously hardcoded as constants in the code, and it makes sense removing that part as long as the human operator has the ability to customize them. This also aligns the glance-operator with the work already done in both Manila and Cinder. Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
expose_cronjob_params
branch
from
85e98da to
8b44f08
Compare
|
/test functional |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7c87bfa
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the current glance CR to expose both
dbPurgeAgeanddbPurgeScheduleas customizable parameters. They were previously hardcoded as constants in the code, and it makes sense removing that part as long as the human operator has the ability to customize them. This also aligns theglance-operatorwith the work already done in bothManilaandCinder.