Add missing GlanceAPI webhook #363
Conversation
| @@ -5,7 +5,6 @@ metadata: | |||
| spec: | |||
| serviceUser: glance | |||
| serviceAccount: glance | |||
| containerImage: quay.io/podified-antelope-centos9/openstack-glance-api:current-podified | |||
|
/test glance-operator-build-deploy-tempest |
api/v1beta1/glanceapi_webhook.go
Outdated
| // log is for logging in this package. | ||
| var glanceapilog = logf.Log.WithName("glanceapi-resource") | ||
|
|
||
| // SetupGlanceAPIDefaults - initialize Glance spec defaults for use with either internal or external webhooks |
There was a problem hiding this comment.
nit: s/initialize Glance/initialize GlanceAPI/
There was a problem hiding this comment.
Good catch, updating it
|
/test glance-operator-build-deploy-tempest |
| // SetupGlanceAPIDefaults - initialize GlanceAPI spec defaults for use with either internal or external webhooks | ||
| func SetupGlanceAPIDefaults(defaults GlanceAPIDefaults) { | ||
| glanceAPIDefaults = defaults | ||
| glancelog.Info("Glance defaults initialized", "defaults", defaults) | ||
| } |
There was a problem hiding this comment.
I think we also need something that pulls-in the ENV vars and sets them in the GlanceAPIDefaults, like we do here [1]. Maybe I just am missing where you're already doing this, however.
[1]
glance-operator/api/v1beta1/common.go
Lines 114 to 121 in 66fbd23
There was a problem hiding this comment.
You're right, I need that function too in common.go. Updating the patch in a moment.
In general it is not allowed to create a glanceAPI instance without defining the top-level Glance CR. However, if for any, unknown reason a glanceAPI CR is created, it will always fail because of the required .spec.ContainerImage field that appears to be empty or simply not defined. This patch introduces the glanceAPI missing webhook that covers at the glanceAPI level the ContainerImage propagationa/definition. Signed-off-by: Francesco Pantano <[email protected]>
|
/test glance-operator-build-deploy-tempest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f304ac5
into
openstack-k8s-operators:main
In general it is not allowed to create a
glanceAPIinstance without defining the top-levelGlanceCR.However, if for any, unknown reason a
glanceAPICRis created, it will always fail because of the required.spec.ContainerImagefield that appears to be empty or simply not defined.This patch introduces the
glanceAPImissingwebhookthat covers at theglanceAPIlevel theContainerImagepropagation/definition.