-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the old Ceph section from cinder.conf #115
Remove the old Ceph section from cinder.conf #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind updating this PR to include updating the readme which still has cephBackend? Perhaps update it to have the new method. I could also take care of that in a follow up PR if you prefer to have two. Either way I agree we should have this change.
This patch just removes the unused ceph section in cinder.conf. The extraVolumes approach is used when cinder is configured with a Ceph backend, so this section is not required anymore. Signed-off-by: Francesco Pantano <[email protected]>
I updated the Readme removing the old (and wrong) information. I added the reference to the [1] #77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Francesco.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, fultonj, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch just removes the unused ceph section in cinder.conf.
The
extraVolumes
approach is used when cinder is configured with a Ceph backend, so this section is not required anymore.Signed-off-by: Francesco Pantano [email protected]