Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use make openstack_init in kuttl test playbook #2658

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Use make openstack_init in kuttl test playbook #2658

merged 1 commit into from
Jan 22, 2025
+4 −24

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented Jan 16, 2025 •
edited
Loading

We're installing openstack operator using 'make openstack' and waiting
for the subscription and installplan, but due to a recent change to the
CRDs [1], we need to also wait for the csv before proceeding. Using
'make openstack_init' from install_yamls should fix the issue, as done
in [2].

[1] openstack-k8s-operators/openstack-operator#1185
[2] openshift/release#60702

Related-Issue: #OSPRH-11244
Depends-On: openstack-k8s-operators/install_yamls#999

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

This was referenced Jan 16, 2025
Merged
Merged
@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch 2 times, most recently from c01633f to bc7e6c7 Compare January 16, 2025 18:59
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a0469858b6174448b86ed8fa4f15bacc

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 11s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 25s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 36s
❌ cifmw-multinode-kuttl FAILURE in 1h 48m 05s
✔️ build-push-container-cifmw-client SUCCESS in 22m 41s

@raukadah raukadah mentioned this pull request Jan 17, 2025
Draft
@cescgina
Copy link
Contributor Author

recheck

@cescgina cescgina marked this pull request as ready for review January 17, 2025 08:32
@amoralej amoralej mentioned this pull request Jan 17, 2025
Open
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0df13fa9bd6d4980889275083fd9d0af

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 26s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 18s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 21s
❌ cifmw-multinode-kuttl FAILURE in 2h 01m 33s
✔️ build-push-container-cifmw-client SUCCESS in 21m 56s

@cescgina
Copy link
Contributor Author

recheck

@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b5c7b2bc670846d994def62499a26db2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 15s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 48s
❌ cifmw-multinode-kuttl FAILURE in 2h 03m 08s
✔️ build-push-container-cifmw-client SUCCESS in 23m 03s

@amoralej amoralej mentioned this pull request Jan 17, 2025
Merged
@cescgina
Copy link
Contributor Author

recheck

This was referenced Jan 17, 2025
Merged
Merged
@amoralej amoralej mentioned this pull request Jan 17, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4e48c21efcb84d5e92bde9404f637429

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 07s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 48s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 17s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 55s
❌ cifmw-multinode-kuttl FAILURE in 2h 01m 22s
✔️ build-push-container-cifmw-client SUCCESS in 23m 17s

@raukadah
Copy link
Contributor

barbican kuttl tests are failing https://logserver.rdoproject.org/58/2658/bc7e6c76b42058a244cc256eadc04470ebc5ea14/github-check/cifmw-multinode-kuttl/f7456a7/job-output.txt

 + oc apply -f -
2025-01-17 12:00:05.879165 | controller |     Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "mmemcached.kb.io": failed to call webhook: Post "https://infra-operator-webhook-service.openstack-operators.svc:443/mutate-memcached-openstack-org-v1beta1-memcached?timeout=10s": tls: failed to verify certificate: x509: certificate is valid for infra-operator-controller-manager-service.openstack-operators, infra-operator-controller-manager-service.openstack-operators.svc, not infra-operator-webhook-service.openstack-operators.svc
2025-01-17 12:00:05.891279 | controller |     + sleep 14
2025-01-17 12:00:05.891324 | controller |     + '[' 15 -eq 15 ']'
2025-01-17 12:00:05.891334 | controller |     + '[' 15 -lt 15 ']'
2025-01-17 12:00:05.891342 | controller |     make: *** [Makefile:1131: memcached_deploy] Error 1

@cescgina
Use make openstack_init in kuttl test playbook
9286fa3 
We're installing openstack operator using 'make openstack' and waiting
for the subscription and installplan, but due to a recent change to the
CRDs [1], we need to also wait for the csv before proceeding. Using
'make openstack_init' from install_yamls should fix the issue, as done
in [2].

[1] openstack-k8s-operators/openstack-operator#1185
[2] openshift/release#60702

Related-Issue: #OSPRH-11244
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4a0f1aad1b0c47349c44837aa2d2c6e0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 13s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 05s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 03s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 22s
❌ cifmw-multinode-kuttl TIMED_OUT in 2h 35m 41s
✔️ build-push-container-cifmw-client SUCCESS in 22m 52s

@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch from c8cd6d6 to 7342c39 Compare January 21, 2025 08:00
@cescgina cescgina mentioned this pull request Jan 21, 2025
Merged
@raukadah raukadah mentioned this pull request Jan 21, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/47e38de64a0a47d5b5476b2d634cb21d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 51s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 38s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 38s
❌ cifmw-multinode-kuttl TIMED_OUT in 4h 08m 48s
✔️ build-push-container-cifmw-client SUCCESS in 22m 10s

@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch from 7342c39 to 7532b03 Compare January 21, 2025 12:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

The job "cifmw-multinode-kuttl" exceeds tenant max-job-timeout 18000.

The problem appears in the the "cifmw-multinode-kuttl" job stanza:

job:
name: cifmw-multinode-kuttl
parent: cifmw-base-multinode-kuttl
timeout: 19800
files:
- ^ci/playbooks/kuttl/.*
- ^scenarios/centos-9/kuttl.yml
- ^zuul.d/kuttl.yaml
vars:
...

in "openstack-k8s-operators/ci-framework/zuul.d/kuttl_multinode.yaml@main", line 52

@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch 2 times, most recently from 1b6ef4b to 6506ba0 Compare January 21, 2025 16:04
@amoralej amoralej mentioned this pull request Jan 21, 2025
Merged
@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch 3 times, most recently from 7325246 to 4ce531d Compare January 21, 2025 18:22
@tosky
Copy link
Contributor

tosky commented Jan 21, 2025

Can you please update the description of the pull request too? Judging by the content of the commits being added, Its scope is increasing compared to the current description.

@cescgina cescgina marked this pull request as draft January 21, 2025 20:08
@cescgina
Copy link
Contributor Author

Can you please update the description of the pull request too? Judging by the content of the commits being added, Its scope is increasing compared to the current description.

I'm just trying to make the job cifmw-multinode-kuttl job to pass, I don't plan to merge it as is. After the current run I'll try a different fix from install_yamls that should only require the first commit on the PR. I'm marking the PR as draft for now until I get some results

@cescgina cescgina force-pushed the kuttl_use_openstack_wait branch from 4ce531d to 9286fa3 Compare January 22, 2025 08:25
@cescgina cescgina marked this pull request as ready for review January 22, 2025 11:02
frenzyfriday
frenzyfriday approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 896b397 into main Jan 22, 2025
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the kuttl_use_openstack_wait branch January 22, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino pablintino left review comments

@marios marios marios left review comments

@frenzyfriday frenzyfriday frenzyfriday approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale is a code owner

@fultonj fultonj Awaiting requested review from fultonj

@fmount fmount Awaiting requested review from fmount

@abays abays Awaiting requested review from abays

Assignees

@frenzyfriday frenzyfriday

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cescgina @pablintino @raukadah @abays @tosky @marios @frenzyfriday