Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polarion] Quote the custom_fields parameter to be shell safe #2636

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[polarion] Quote the custom_fields parameter to be shell safe #2636

merged 1 commit into from
Jan 9, 2025

Conversation

jirimacku
Copy link
Contributor

As the polarion allows white space characters in the properties we need to quote it to not fail in the shell task.

@github-actions github-actions bot marked this pull request as draft January 8, 2025 16:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@jirimacku jirimacku marked this pull request as ready for review January 8, 2025 16:39
@tosky
Copy link
Contributor

tosky commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2025
@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 501c9de into openstack-k8s-operators:main Jan 9, 2025
6 checks passed
@jirimacku
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot
Copy link

@jirimacku: new pull request created: #2638

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosky tosky Awaiting requested review from tosky tosky is a code owner

@ciecierski ciecierski Awaiting requested review from ciecierski ciecierski is a code owner

@jparoly jparoly Awaiting requested review from jparoly jparoly is a code owner

Assignees

@abays abays

@tosky tosky

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jirimacku @tosky @pablintino @openshift-cherrypick-robot @abays