Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the role #2610

Closed
wants to merge 2 commits into from
Closed

Simplify the role #2610

wants to merge 2 commits into from

Conversation

vakwetu
Copy link
Contributor

@vakwetu vakwetu commented Dec 16, 2024

lunasa hsm role

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft December 16, 2024 20:18
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@vakwetu vakwetu force-pushed the simplify_the_role branch 2 times, most recently from 72201c9 to 8c467dd Compare December 16, 2024 21:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7dfb11899c134831a845c3f12ba28f18

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 11s
❌ cifmw-pod-pre-commit FAILURE in 7m 39s
✔️ build-push-container-cifmw-client SUCCESS in 38m 25s
✔️ cifmw-molecule-update_containers SUCCESS in 4m 56s

@vakwetu vakwetu force-pushed the simplify_the_role branch 6 times, most recently from 0625d25 to 7a18d25 Compare December 18, 2024 18:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b5e136308190410085a9a4c3d64c4d39

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 53s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 20s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 05s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 51s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 46s
✔️ build-push-container-cifmw-client SUCCESS in 36m 13s
✔️ cifmw-molecule-update_containers SUCCESS in 4m 11s

vakwetu added 2 commits January 2, 2025 15:33
@vakwetu
Add HSM Prep role
1c2f8a5 
Also add a playbook to call this role as a pre_deploy playbook
so that we can create and use the modified images in our barbican tests.
@vakwetu
Simplify the role
9445f09 
Lets take all the dependencies on a running lunaclient VM
out.  We suspect that with the ip checking turned off, we can use
any subject in the client certs anyway, as long as the cert is uploaded
to the HSM (and registered to a client).

This simplifies things considerably - and makes the role more
reusable by a deployer as a standalone role.

Instead, we'll need the relevant bits uploaded somewhere for the
deployer to retrieve.
@vakwetu vakwetu force-pushed the simplify_the_role branch from 7a18d25 to 9445f09 Compare January 2, 2025 15:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/173ffe4800be4d5fb68c8db9591721d4

❌ openstack-k8s-operators-content-provider FAILURE in 4m 48s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 02s
✔️ build-push-container-cifmw-client SUCCESS in 38m 33s
❌ cifmw-molecule-update_containers FAILURE in 5m 19s

@lewisdenny
Copy link
Collaborator

Hi @vakwetu, please add a more detailed commit message and link to a Jira card explaining the context of your work here.

Also, please squash you two commits and let us know if you need help with the CI failures.

@vakwetu
Copy link
Contributor Author

vakwetu commented Jan 6, 2025

@lewisdenny thanks - I'm actually going to close this PR as I've decided to move most of this logic to an ansible role in a new repo.
The new PR (which makes use of this new role) is #2630

@vakwetu vakwetu closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino Awaiting requested review from pablintino pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vakwetu @lewisdenny