Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCN] Update network values template #2597

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[DCN] Update network values template #2597

merged 1 commit into from
Dec 16, 2024

Conversation

sbekkerm
Copy link
Contributor

@sbekkerm sbekkerm commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

Explicitly set the route table ID to prevent random assignment, which can lead to the unexpected re-creation of VLAN interfaces.

Related Issue: OSPRH-9899

@sbekkerm
[DCN] Update network values template
c668d3a 
Explicitly set the route table ID to prevent random assignment,
which can lead to the unexpected re-creation of VLAN interfaces.

Related Issue: OSPRH-9899
@github-actions github-actions bot marked this pull request as draft December 12, 2024 13:12
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@sbekkerm sbekkerm marked this pull request as ready for review December 12, 2024 13:12
hjensas
hjensas reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7c36a5a into openstack-k8s-operators:main Dec 16, 2024
6 checks passed
@sbekkerm
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot
Copy link

@sbekkerm: new pull request created: #2613

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjensas hjensas hjensas left review comments

Assignees

@hjensas hjensas

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbekkerm @pablintino @openshift-cherrypick-robot @hjensas