Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoption_osp_deploy - os-net-config ironic #2593

Merged
merged 1 commit into from
Dec 16, 2024
Merged

adoption_osp_deploy - os-net-config ironic #2593

merged 1 commit into from
Dec 16, 2024

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Dec 11, 2024

Set up the ironic network interface on osp controller nodes if the network is defined in the scenario.

By default it will map to nic3, but it can be overriden in the adoption scenario by setting os_net_config_ironic_iface in the scenario defenition.

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft December 11, 2024 00:54
@hjensas hjensas marked this pull request as ready for review December 11, 2024 01:32
@hjensas
adoption_osp_deploy - os-net-config ironic
8c769de 
Set up the ironic network interface on osp controller nodes if the
network is defined in the scenario.

By default it will map to `nic3`, but it can be overriden in the
adoption scenario by setting `os_net_config_ironic_iface` in the
scenario defenition.
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/321f60ac75e04262a20519c0f5e80798

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 10s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 47s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 40s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 07s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s
✔️ build-push-container-cifmw-client SUCCESS in 20m 56s

@lewisdenny
Copy link
Collaborator

recheck

@hjensas hjensas requested a review from a team December 12, 2024 03:10
lewisdenny
lewisdenny approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@hjensas hjensas requested review from a team, cescgina and ciecierski December 13, 2024 09:23
@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lewisdenny,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit db9f16d into openstack-k8s-operators:main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisdenny lewisdenny lewisdenny approved these changes

@cescgina cescgina Awaiting requested review from cescgina

@ciecierski ciecierski Awaiting requested review from ciecierski

Assignees

@pablintino pablintino

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjensas @lewisdenny @pablintino