Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook file for federation configuration #2588

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add hook file for federation configuration #2588

wants to merge 1 commit into from
+92 −0

Conversation

millevy
Copy link

@millevy millevy commented Dec 5, 2024

Add hook file for federation configuration

@github-actions github-actions bot marked this pull request as draft December 5, 2024 13:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@millevy millevy force-pushed the costumize_federation_hook_file branch 2 times, most recently from d573d83 to b8f0ca3 Compare December 10, 2024 10:37
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7d7bd0a98fd44e73a099951c3f8cd524

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 18s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 27s
❌ cifmw-pod-pre-commit FAILURE in 7m 27s
✔️ build-push-container-cifmw-client SUCCESS in 37m 27s

@millevy millevy force-pushed the costumize_federation_hook_file branch from b8f0ca3 to 38f7d20 Compare December 11, 2024 11:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e0322feb6d644478bf760e044d9148f8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 58s
❌ cifmw-pod-pre-commit FAILURE in 7m 18s
✔️ build-push-container-cifmw-client SUCCESS in 38m 08s

@millevy
Copy link
Author

millevy commented Dec 11, 2024

recheck

d34dh0r53
d34dh0r53 previously approved these changes Dec 11, 2024
View reviewed changes
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87ab73fba74f4dc1aadaefcf231e7853

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 35m 06s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 45s
❌ cifmw-pod-pre-commit FAILURE in 7m 13s
✔️ build-push-container-cifmw-client SUCCESS in 37m 06s

@millevy millevy force-pushed the costumize_federation_hook_file branch from 38f7d20 to 47a647c Compare December 15, 2024 11:18
@millevy
Copy link
Author

millevy commented Dec 16, 2024

recheck

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/326eddd63760419e86e5489961ed3770

❌ openstack-k8s-operators-content-provider FAILURE in 5m 16s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 23s
✔️ build-push-container-cifmw-client SUCCESS in 33m 39s

@github-actions github-actions bot removed the Stale label Jan 3, 2025
@millevy
Copy link
Author

millevy commented Jan 6, 2025

recheck

@github-actions GitHub Actions
Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@github-actions github-actions bot removed the Stale label Jan 23, 2025
@millevy millevy force-pushed the costumize_federation_hook_file branch from 96f8ef4 to b159813 Compare January 23, 2025 10:08
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@millevy millevy force-pushed the costumize_federation_hook_file branch from b159813 to 42cf5ed Compare January 23, 2025 12:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1d50d60fada94caf9a8c568e424cc252

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 28s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 32s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 25s
✔️ build-push-container-cifmw-client SUCCESS in 37m 32s

Deydra71
Deydra71 reviewed Jan 24, 2025
View reviewed changes
hooks/playbooks/OpenStackControlPlane-federationPatch.yaml Outdated
oidcProviderMetadataURL: "{{ cifmw_keystone_OIDC_ProviderMetadataURL }}"
oidcResponseType: "{{ cifmw_keystone_OIDC_ResponseType }}"
oidcScope: "{{ cifmw_keystone_OIDC_Scope }}"
remoteIDAttribute: "{{ cifmw_keystone_OIDC_remoteIDAttribute }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have oidcFederation type, all federation parameters are provided via a secret (more on slack)

@millevy millevy force-pushed the costumize_federation_hook_file branch from 1cf1183 to 61ad544 Compare January 26, 2025 13:04
@millevy millevy force-pushed the costumize_federation_hook_file branch from 61ad544 to 68d511e Compare January 26, 2025 13:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/06dc564488f241c0b0572315228096f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 32s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 17s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 36m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 54s
❌ cifmw-pod-pre-commit FAILURE in 7m 13s
✔️ build-push-container-cifmw-client SUCCESS in 22m 33s

@millevy millevy force-pushed the costumize_federation_hook_file branch from 68d511e to 2bb6b89 Compare January 27, 2025 11:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab49f63e266642a4be008e7794c80a3a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 45m 49s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 29m 57s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 49m 44s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
❌ cifmw-pod-pre-commit FAILURE in 7m 29s
✔️ build-push-container-cifmw-client SUCCESS in 17m 10s

@millevy millevy force-pushed the costumize_federation_hook_file branch from 2bb6b89 to c657d85 Compare February 9, 2025 13:15
Add hook file for federation configuration
ee4c1f3 
Add hook file for federation configuration
@millevy millevy force-pushed the costumize_federation_hook_file branch from c657d85 to ee4c1f3 Compare February 9, 2025 13:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/da49ddb574234c36a6232b055fc28196

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 03s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 11m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 14s
✔️ build-push-container-cifmw-client SUCCESS in 23m 06s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzyfriday frenzyfriday frenzyfriday left review comments

@Deydra71 Deydra71 Deydra71 left review comments

@d34dh0r53 d34dh0r53 d34dh0r53 left review comments

@pablintino pablintino Awaiting requested review from pablintino pablintino will be requested when the pull request is marked ready for review pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny will be requested when the pull request is marked ready for review lewisdenny is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp will be requested when the pull request is marked ready for review evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale will be requested when the pull request is marked ready for review bshewale is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millevy @d34dh0r53 @frenzyfriday @Deydra71