Set Cinder customServiceConfig globally in DCN DT #2582
Conversation
|
Thanks for the PR! ❤️ |
The customServiceConfig for cinder in the DCN DT is used to set the storage_availability_zone. We wish to do this for all Cinder services in the default site (`az0`), not just for cinderAPI or cinderBackup as the AZ was missing from the cinder-scheduler. Thus, we will move it to the global section under the cinder template and out of the cinderAPI and cinderBackup since they will inherit it. The backend_availability_zone is kept inside of the cinderVolumes loop since it needs to be set for other AZs. There's no harm in letting the loop set it for az0 and it's simpler to do that than add a conditional. Jira: https://issues.redhat.com/browse/OSPRH-11915 Signed-off-by: John Fulton <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9c95009
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr1 |
|
@fultonj: new pull request created: #2599 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The customServiceConfig for cinder in the DCN DT is used to set the storage_availability_zone. We wish to do this for all Cinder services in the default site (
az0), not just for cinderAPI or cinderBackup as the AZ was missing from the cinder-scheduler. Thus, we will move it to the global section under the cinder template and out of the cinderAPI and cinderBackup since they will inherit it. The backend_availability_zone is kept inside of the cinderVolumes loop since it needs to be set for other AZs. There's no harm in letting the loop set it for az0 and it's simpler to do that than add a conditional.Jira: https://issues.redhat.com/browse/OSPRH-11915