Add empty list as default for adoption scenarios without networker nodes #2581
Conversation
Networker nodes are not required in all adoption topologies. We need to provide default filter to be able to generate adoption_vars template if osp-networkers are not defined in _vm_groups. Fixes: openstack-k8s-operators#2548
|
Thanks for the PR! ❤️ |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/567f9d05177d4dcf98be90f49f7dec81 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 01s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b63f1b0ee79f4b1aa08be59c0f2cb158 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 31s |
|
recheck |
|
The previous run's have failed applying NNCP. This install_yaml's make target - https://github.com/openstack-k8s-operators/install_yamls/blob/main/Makefile#L2270-L2273 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 79a60e4
into
openstack-k8s-operators:main
Networker nodes are not required in all adoption topologies.
We need to provide default filter to be able to generate adoption_vars
template if osp-networkers are not defined in _vm_groups.
Fixes: #2548