Pin dependencies to avoid deps break CI #2575
Conversation
|
Thanks for the PR! ❤️ |
There was a problem hiding this comment.
Thank you @pablintino
What about dogpile.cache and ansible-core in test-requirements.txt? Can we not pin them?
I also verified we can use ansible-core 2.15, I was concerned because we we are still using RHEL 9 default Python of 3.9, but ansible-core 2.15 supports 3.9 and is the latest release we can use:
https://github.com/ansible/ansible/blob/c89e95163fb1dceddf7abbefbb2e008aab9bef3c/setup.cfg#L40
pablintino
force-pushed
the
pin-version
branch
from
47b1cc2 to
d09feda
Compare
doh! I missed those two. The ansible-core was already pinned in the common file with 2.15.3, that we can definitely use. |
|
recheck |
|
recheck |
pablintino
force-pushed
the
pin-version
branch
from
d09feda to
224fb3f
Compare
pablintino
force-pushed
the
pin-version
branch
from
224fb3f to
0173d91
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Till this commit we were not pinning the dependencies, resulting in break jobs as soon as a dependency changed underneath without notice. This commit pins all the dependencies to given known versions.
pablintino
force-pushed
the
pin-version
branch
from
0173d91 to
d0973db
Compare
|
@pablintino I think there is a change with the Ansible version that is effecting how the vars/default vars are picked up in the Molecule tests :/ |
Till this commit we were not pinning the dependencies, resulting in break jobs as soon as a dependency changed underneath without notice. This commit pins all the dependencies to given known versions.