-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new OpenStack initialization resource for RHOSO install #2549
Support new OpenStack initialization resource for RHOSO install #2549
Conversation
Skipping CI for Draft Pull Request. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
I have tested this with VA1 and a custom build of the new OpenStack operator that uses the new paradigm. The deployment was succesful, even all the way through Tempest. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abays
I assume we will need to support the new and old method of installing RHOSO?
If so, could you please explain how that will be handled as we don't really version ci-framework.
That's a good point. CIFMW will still need to deploy older releases. So I will need to add some sort of conditional logic that detects whether the new |
0028939
to
c663657
Compare
code here looks good to me. Thanks abays |
@pablintino @lewisdenny With openstack-k8s-operators/install_yamls#981 merged, we now have Prow all set to handle both old and new OpenStack operator install paradigms. If we can get this PR merged, then we should be in the same situation for Zuul. I'll keep an eye on the Zuul jobs here to try to get them to pass. I don't think the recent failures have been related to my changes. |
roles/edpm_prepare/tasks/main.yml
Outdated
- _cifmw_kustomize_deploy_olm_osp_operator_openstack_crd_out.resources is defined | ||
- (_cifmw_kustomize_deploy_olm_osp_operator_openstack_crd_out.resources | length) > 0 | ||
vars: | ||
make_openstack_env: "{{ cifmw_edpm_prepare_common_env | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: make_openstack_env
should be make_openstack_init_env
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3877d4aba6b948a189362711dffb1ac7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 05m 00s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e049474f1bf4f05b02dcd3e907dc4e0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 35s |
26776bc
to
8e61334
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5218f089e82c43d0b1c2bd4175b21dab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 11m 34s |
The latest failures are indeed caused by my changes, but I am confused how they are happening. The issue is that
Maybe there's something wrong with [1], but it succeeded earlier this week and I haven't changed it other than to rename [2]...but maybe that did it? [1] https://github.com/abays/ci-framework/blob/8e613342016c94a6bc90df0c3c5fa238d6e26367/roles/edpm_prepare/tasks/main.yml#L122-L148 |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f98c7d01ff02473a9f3f8626446d41cc ✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 12m 34s |
recheck |
/lgtm |
fc30400
into
openstack-k8s-operators:main
We have a new upcoming way to install and deploy the OSP operators. OLM will only install one CRD for OSP, which is an initialization resource. A CR must be created for that CRD, which then, when created, causes all the remaining OSP CRDs to be installed and also deploys their respective operators.