[test-operator][horizon] Fix Horizon CR name #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
This patch ensures that we are creating Horizon CR instance with name set to a value that we later search for when requesting a status of openshift jobs. Previously we were creating Horizon CR with name horizontest name but were querying jobs with name horizontest-tests [1]. [1] https://github.com/openstack-k8s-operators/ci-framework/blob/ad0110d522dac0a1f3637c4207c45ac36b827ef3/roles/test_operator/vars/main.yml#L20
lpiwowar
force-pushed
the
fix/horizon-name
branch
from
d1df594 to
b897694
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit f114b11
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we are creating Horizon CR instance with name set to a value that we later search for when requesting a status of openshift jobs.
Previously we were creating Horizon CR with name horizontest name but were querying jobs with name horizontest-tests [1].
[1] test_operator vars
As a pull request owner and reviewers, I checked that: