Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Add playbook for Octavia amphora image #2176

Closed
wants to merge 1 commit into from
Closed

[Draft] Add playbook for Octavia amphora image #2176

wants to merge 1 commit into from

Conversation

gthiemonge
Copy link

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft July 30, 2024 07:09
pablintino
pablintino reviewed Jul 30, 2024
View reviewed changes
hooks/playbooks/octavia-amphora-image-upload.yml Outdated
ansible.builtin.shell: |
crname=$(oc get openstackcontrolplane -o name -n {{ namespace }})
# TODO: replace with D/S image
oc patch ${crname} -n {namespace} --type=merge --patch \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've the feeling {namespace} should be {{namespace}} here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... thanks! good catch

@gthiemonge gthiemonge force-pushed the octavia_amphora_image branch 2 times, most recently from 0ce19d5 to 2454328 Compare July 30, 2024 09:24
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dc2a9c3280d640f5a13b7afea796d74f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 28s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 13s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 32m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 58s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 13s

@gthiemonge gthiemonge force-pushed the octavia_amphora_image branch from 2454328 to eec755d Compare August 1, 2024 07:01
@pablintino
Copy link
Collaborator

Implemented in DS, not needed in upstream anymore.

@pablintino pablintino closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino pablintino left review comments

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny will be requested when the pull request is marked ready for review lewisdenny is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp will be requested when the pull request is marked ready for review evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale will be requested when the pull request is marked ready for review bshewale is a code owner

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday frenzyfriday will be requested when the pull request is marked ready for review frenzyfriday is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthiemonge @pablintino