manila share type: do not fail if share exists

[queria]

When cifmw deployment/reproducer is rerun (e.g. for scale-out), it always fails in manila-create-default-resources hook since the default share already exists.

OSPRH-8983

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running
• Appropriate documentation exists and/or is up-to-date:
  • README in the role
  • Content of the docs/source is reflecting the changes

[github-actions]

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

[tosky]

Maybe it would make it sense to split it into the create (and not fail if it exists)) and one to assign the additional spec

[gouthampacha]

yes; wouldn't it?

---
- name: Create Manila resources needed for tempest run
  hosts: "{{ cifmw_target_hook_host | default('localhost') }}"
  gather_facts: false
  vars:
    share_type_name: "default"
    driver_handles_share_servers: "False"
    extra_specs:
      snapshot_support: "True"
      create_share_from_snapshot_support: "True"
  tasks:
    - name: Check if the Manila share type already exists
       environment:
        KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
        PATH: "{{ cifmw_path }}"
      ansible.builtin.shell: |
        oc -n {{ namespace }} exec -it pod/openstackclient \
        -- openstack share type list -f value -c Name | grep -w "{{ share_type_name }}"
      register: share_type_exists
      ignore_errors: true
    - name: Create the Manila share type if it does not exist
      environment:
        KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
        PATH: "{{ cifmw_path }}"
      ansible.builtin.shell: |
        oc -n {{ namespace }} exec -it pod/openstackclient \
        openstack share type create "{{ share_type_name }}" \
           "{{ driver_handles_share_servers }}" \
           {{ ' '.join('--extra-specs ' + k + '=' + v for k, v in extra_specs.items()) }}
      when: share_type_exists.rc != 0

[queria]

hm this seems as just more verbose 'exists - or create',
it does not cover the case when it may exist but without expected properties

what tosky suggests (and i agree its at least safer) is more like:

• share type create (failed_when: failed && not already-exists)
• share type update to set properties // assuming this does not fail if properties already match (will check)

[queria]

I've updated this to align with both - to do create|ignore-existing + update properties ... and use the syntax/approach based on vars for name and extra_specs dictionary.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7f96838ee9d140debe350e3aafb01e44

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 23s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 40s
❌ cifmw-pod-pre-commit FAILURE in 8m 05s

[tosky]

Looks good now - @gouthampacha what do you think?

[gouthampacha]

Great; thanks @queria

[gouthampacha]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment