Adds missing "mode" to tasks with copy and file modules #1425

frenzyfriday · 2024-04-08T16:17:19Z

As a pull request owner and reviewers, I checked that:

Appropriate testing is done and actually running
Appropriate documentation exists and/or is up-to-date:
- README in the role
- Content of the docs/source is reflecting the changes

softwarefactory-project-zuul · 2024-04-08T19:24:23Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b230179341c94d489840ab7efa50313e

❌ openstack-k8s-operators-content-provider POST_FAILURE in 3h 04m 42s
❌ podified-multinode-edpm-deployment-crc POST_FAILURE in 56m 14s
❌ podified-multinode-hci-deployment-crc POST_FAILURE in 1h 15m 03s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc POST_FAILURE in 2h 15m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 29s (non-voting)
❌ cifmw-baremetal-nested-crc POST_FAILURE in 1h 02m 01s
✔️ cifmw-molecule-artifacts SUCCESS in 4m 51s
✔️ cifmw-molecule-cert_manager SUCCESS in 15m 13s
✔️ cifmw-molecule-ci_metallb SUCCESS in 15m 06s
✔️ cifmw-molecule-ci_nmstate SUCCESS in 17m 01s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 5m 03s
✔️ cifmw-molecule-devscripts SUCCESS in 7m 13s
✔️ cifmw-molecule-edpm_deploy SUCCESS in 5m 13s
✔️ cifmw-molecule-edpm_kustomize SUCCESS in 5m 13s
✔️ cifmw-molecule-hci_prepare SUCCESS in 4m 52s
❌ cifmw-molecule-install_openstack_ca FAILURE in 20m 13s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 29s
✔️ cifmw-molecule-manage_secrets SUCCESS in 17m 24s
❌ cifmw-molecule-pkg_build FAILURE in 6m 53s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 43s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 19s
✔️ cifmw-molecule-run_hook SUCCESS in 4m 23s
✔️ cifmw-molecule-tempest SUCCESS in 6m 18s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 39s
✔️ cifmw-molecule-tofu SUCCESS in 22m 45s

softwarefactory-project-zuul · 2024-04-09T10:27:30Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

playbooks/99-logs.yml

cjeanner · 2024-04-10T14:24:17Z

roles/repo_setup/tasks/sync_repos.yml

@@ -23,6 +23,7 @@
    - name: Copy generated repos to /etc/yum.repos.d directory
      become: true
      ansible.builtin.copy:
+        mode: "0644"


beware, this is a directory, it needs "0755"

ack, updated

roles/reproducer/tasks/ci_job.yml

softwarefactory-project-zuul · 2024-04-10T17:20:49Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/49ee71b3b5cc452ab22cc3970c67dd8b

❌ openstack-k8s-operators-content-provider POST_FAILURE in 2h 36m 31s
❌ podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 15m 18s
❌ podified-multinode-hci-deployment-crc POST_FAILURE in 1h 31m 09s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc POST_FAILURE in 2h 10m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 24s (non-voting)
❌ cifmw-baremetal-nested-crc POST_FAILURE in 1h 17m 09s
✔️ cifmw-molecule-artifacts SUCCESS in 6m 33s
❌ cifmw-molecule-cert_manager FAILURE in 19m 27s
✔️ cifmw-molecule-ci_metallb SUCCESS in 16m 24s
✔️ cifmw-molecule-ci_nmstate SUCCESS in 16m 03s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 6m 30s
✔️ cifmw-molecule-devscripts SUCCESS in 9m 49s
✔️ cifmw-molecule-edpm_deploy SUCCESS in 5m 24s
✔️ cifmw-molecule-edpm_kustomize SUCCESS in 5m 34s
✔️ cifmw-molecule-hci_prepare SUCCESS in 5m 03s
❌ cifmw-molecule-install_openstack_ca FAILURE in 21m 15s
❌ cifmw-molecule-kustomize_deploy FAILURE in 5m 17s
✔️ cifmw-molecule-manage_secrets SUCCESS in 20m 07s
❌ cifmw-molecule-pkg_build FAILURE in 7m 12s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 17s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 29s
✔️ cifmw-molecule-run_hook SUCCESS in 4m 34s
✔️ cifmw-molecule-tempest SUCCESS in 5m 18s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 07s
✔️ cifmw-molecule-tofu SUCCESS in 22m 50s

lewisdenny

Looks good @frenzyfriday, thank you!

Are you going to enable risky-file-permissions lint so we can see if this now passes CI on this patch? [1]

[1] https://github.com/openstack-k8s-operators/ci-framework/blob/8cd2a2db84b2c89af8f854948b620f9462065501/.ansible-lint#L43C5-L43C27

softwarefactory-project-zuul · 2024-04-29T10:18:49Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 1425,bc0b20ad9ea0472903752b4f8af6401b5f9c49c2

softwarefactory-project-zuul · 2024-04-29T13:36:53Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ead78025415e4ee19336e2d1223040fc

softwarefactory-project-zuul · 2024-06-06T14:59:14Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/81b34822ab0b4da59cdb1035de3fa021

softwarefactory-project-zuul · 2024-07-02T11:46:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/918e3cb127064a8b9f0dfd8357597281

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007433115 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-hci-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-multinode-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test NODE_FAILURE Node request 100-0007433116 failed in 0s
❌ cifmw-pod-pre-commit NODE_FAILURE Node request 100-0007433117 failed in 0s
✔️ cifmw-baremetal-nested-crc SUCCESS in 1h 03m 16s
✔️ cifmw-content-provider-build-images SUCCESS in 15m 03s
✔️ cifmw-edpm-build-images SUCCESS in 14m 05s
❌ cifmw-tcib NODE_FAILURE Node request 100-0007433121 failed in 0s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 52s
❌ ci-framework-openstack-meta-content-provider NODE_FAILURE Node request 100-0007433123 failed in 0s
✔️ cifmw-molecule-artifacts SUCCESS in 5m 01s
✔️ cifmw-molecule-build_containers SUCCESS in 8m 38s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 17m 19s
❌ cifmw-molecule-cert_manager NODE_FAILURE Node request 100-0007433127 failed in 0s
❌ cifmw-molecule-ci_local_storage NODE_FAILURE Node request 100-0007433128 failed in 0s
❌ cifmw-molecule-ci_metallb NODE_FAILURE Node request 100-0007433129 failed in 0s
❌ cifmw-molecule-ci_netconfig NODE_FAILURE Node request 100-0007433130 failed in 0s
✔️ cifmw-molecule-ci_nmstate SUCCESS in 14m 41s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 5m 07s
✔️ cifmw-molecule-copy_container SUCCESS in 7m 10s
✔️ cifmw-molecule-devscripts SUCCESS in 11m 02s
✔️ cifmw-molecule-edpm_build_images SUCCESS in 4m 42s
✔️ cifmw-molecule-edpm_deploy SUCCESS in 5m 22s
✔️ cifmw-molecule-edpm_kustomize SUCCESS in 4m 55s
❌ cifmw-molecule-env_op_images NODE_FAILURE Node request 100-0007433138 failed in 0s
✔️ cifmw-molecule-hci_prepare SUCCESS in 5m 13s
✔️ cifmw-molecule-install_ca SUCCESS in 5m 15s
❌ cifmw-molecule-install_openstack_ca NODE_FAILURE Node request 100-0007433141 failed in 0s
✔️ cifmw-molecule-install_yamls SUCCESS in 4m 53s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 50s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 15m 50s
❌ cifmw-molecule-manage_secrets NODE_FAILURE Node request 100-0007433145 failed in 0s
✔️ cifmw-molecule-ovirt SUCCESS in 1m 52s
✔️ cifmw-molecule-pkg_build SUCCESS in 23m 43s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 05s
❌ cifmw-molecule-reproducer NODE_FAILURE Node request 100-0007433149 failed in 0s
✔️ cifmw-molecule-run_hook SUCCESS in 4m 31s
❌ cifmw-molecule-set_openstack_containers NODE_FAILURE Node request 100-0007433151 failed in 0s
❌ cifmw-molecule-sushy_emulator NODE_FAILURE Node request 100-0007433152 failed in 0s
✔️ cifmw-molecule-tempest SUCCESS in 5m 08s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 27s
❌ cifmw-molecule-tofu NODE_FAILURE Node request 100-0007433155 failed in 0s
❌ cifmw-molecule-virtualbmc FAILURE in 8m 28s

lewisdenny · 2024-07-24T04:44:40Z

rebased to check current status

softwarefactory-project-zuul · 2024-07-24T07:28:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cc3b216d08aa41368483311348c03625

lewisdenny · 2024-07-24T12:41:46Z

recheck

softwarefactory-project-zuul · 2024-07-24T16:15:02Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a106f7c6252e4e2dbbbe469af8ae295c

lewisdenny

cifmw-molecule-install_openstack_ca is flaky, not a failure due to this patch, I opened a patch to try improve here

The other two failures are an easy fix, I left a suggestion.

This patch is almost ready to get in.

roles/virtualbmc/tasks/main.yml

marios

could only find one this time :)
and directories now look consistent at 0755 I couldn't find any more 0775

tests/integration/targets/make/tasks/ci_make.yml

lewisdenny

/lgtm

Thanks @frenzyfriday

frenzyfriday · 2024-08-15T16:06:12Z

recheck

rlandy · 2024-08-15T22:48:53Z

recheck

raukadah · 2024-08-16T07:30:53Z

recheck after dequeuing stuck zuul jobs

softwarefactory-project-zuul · 2024-08-16T10:54:36Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7e9204524a4e453b88cb571d485c542a

rlandy · 2024-08-19T16:57:25Z

/lgtm

sathlan · 2024-09-11T12:11:47Z

/cherry-pick 18.0.0-proposed

openshift-cherrypick-robot · 2024-09-11T12:12:29Z

@sathlan: new pull request created: #2340

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from adrianfusco and psathyan April 8, 2024 16:17

frenzyfriday force-pushed the mode branch from 810873c to 74f459d Compare April 9, 2024 10:26

frenzyfriday force-pushed the mode branch from 74f459d to fecbae6 Compare April 10, 2024 10:31

cjeanner reviewed Apr 10, 2024

View reviewed changes

cjeanner added the linter label Apr 11, 2024

openshift-merge-robot added the needs-rebase label Apr 20, 2024

lewisdenny requested changes Apr 22, 2024

View reviewed changes

openshift-ci bot assigned lewisdenny Apr 22, 2024

frenzyfriday force-pushed the mode branch from fecbae6 to bc0b20a Compare April 29, 2024 10:18

frenzyfriday force-pushed the mode branch 2 times, most recently from d3e6990 to 5ecf890 Compare April 29, 2024 10:27

openshift-merge-robot removed the needs-rebase label Apr 29, 2024

frenzyfriday force-pushed the mode branch from 5ecf890 to 055f4be Compare April 29, 2024 10:37

frenzyfriday force-pushed the mode branch from 055f4be to 90e96cd Compare June 6, 2024 10:00

frenzyfriday force-pushed the mode branch from 90e96cd to 5eddd09 Compare July 2, 2024 10:42

lewisdenny force-pushed the mode branch from 5eddd09 to b9573f9 Compare July 24, 2024 04:44

openshift-ci bot added the do-not-merge/contains-merge-commits label Jul 25, 2024

lewisdenny requested changes Jul 25, 2024

View reviewed changes

roles/virtualbmc/tasks/main.yml Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/contains-merge-commits label Aug 13, 2024

github-actions bot added the Ready For Review label Aug 13, 2024

frenzyfriday force-pushed the mode branch from 8f21c21 to a28d057 Compare August 14, 2024 09:26

openshift-ci bot removed the do-not-merge/contains-merge-commits label Aug 14, 2024

github-actions bot removed the Ready For Review label Aug 14, 2024

frenzyfriday force-pushed the mode branch from a28d057 to 608290e Compare August 14, 2024 11:17

github-actions bot added the Ready For Review label Aug 14, 2024

marios requested changes Aug 15, 2024

View reviewed changes

tests/integration/targets/make/tasks/ci_make.yml Outdated Show resolved Hide resolved

frenzyfriday force-pushed the mode branch from 608290e to 758dbeb Compare August 15, 2024 09:29

github-actions bot removed the Ready For Review label Aug 15, 2024

lewisdenny approved these changes Aug 15, 2024

View reviewed changes

openshift-ci bot added the lgtm label Aug 15, 2024

marios approved these changes Aug 16, 2024

View reviewed changes

Adds missing "mode" to tasks with copy and file modules

8b46b8b

frenzyfriday force-pushed the mode branch from 758dbeb to 8b46b8b Compare August 19, 2024 10:48

openshift-ci bot removed the lgtm label Aug 19, 2024

github-actions bot added the Ready For Review label Aug 19, 2024

openshift-ci bot added the lgtm label Aug 19, 2024

frenzyfriday removed the do-not-merge/hold label Aug 19, 2024

github-actions bot added Ready For Review and removed Ready For Review labels Aug 19, 2024

openshift-merge-bot bot merged commit 1f9756b into openstack-k8s-operators:main Aug 19, 2024
4 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 11, 2024

[18.0.0-proposed] Adds missing "mode" to tasks with copy and file modules #2340

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds missing "mode" to tasks with copy and file modules #1425

Adds missing "mode" to tasks with copy and file modules #1425

frenzyfriday commented Apr 8, 2024

softwarefactory-project-zuul bot commented Apr 8, 2024

softwarefactory-project-zuul bot commented Apr 9, 2024

cjeanner Apr 10, 2024

frenzyfriday Apr 29, 2024

softwarefactory-project-zuul bot commented Apr 10, 2024

lewisdenny left a comment

softwarefactory-project-zuul bot commented Apr 29, 2024

softwarefactory-project-zuul bot commented Apr 29, 2024

softwarefactory-project-zuul bot commented Jun 6, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

lewisdenny commented Jul 24, 2024

softwarefactory-project-zuul bot commented Jul 24, 2024

lewisdenny commented Jul 24, 2024

softwarefactory-project-zuul bot commented Jul 24, 2024

lewisdenny left a comment

marios left a comment

lewisdenny left a comment

frenzyfriday commented Aug 15, 2024

rlandy commented Aug 15, 2024

raukadah commented Aug 16, 2024

softwarefactory-project-zuul bot commented Aug 16, 2024

rlandy commented Aug 19, 2024

sathlan commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024

Adds missing "mode" to tasks with copy and file modules #1425

Adds missing "mode" to tasks with copy and file modules #1425

Conversation

frenzyfriday commented Apr 8, 2024

softwarefactory-project-zuul bot commented Apr 8, 2024

softwarefactory-project-zuul bot commented Apr 9, 2024

cjeanner Apr 10, 2024

Choose a reason for hiding this comment

frenzyfriday Apr 29, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Apr 10, 2024

lewisdenny left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Apr 29, 2024

softwarefactory-project-zuul bot commented Apr 29, 2024

softwarefactory-project-zuul bot commented Jun 6, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

lewisdenny commented Jul 24, 2024

softwarefactory-project-zuul bot commented Jul 24, 2024

lewisdenny commented Jul 24, 2024

softwarefactory-project-zuul bot commented Jul 24, 2024

lewisdenny left a comment

Choose a reason for hiding this comment

marios left a comment

Choose a reason for hiding this comment

lewisdenny left a comment

Choose a reason for hiding this comment

frenzyfriday commented Aug 15, 2024

rlandy commented Aug 15, 2024

raukadah commented Aug 16, 2024

softwarefactory-project-zuul bot commented Aug 16, 2024

rlandy commented Aug 19, 2024

sathlan commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024