Adding nodeSelector functionality #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
abays
reviewed
Aug 21, 2024
abays
reviewed
Aug 21, 2024
abays
reviewed
Aug 21, 2024
Co-authored-by: Andrew Bays <[email protected]>
Co-authored-by: Andrew Bays <[email protected]>
Co-authored-by: Andrew Bays <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e158d69
into
openstack-k8s-operators:main
6 checks passed
|
/cherry-pick 18.0.0-proposed |
|
@mauricioharley: new pull request created: #154 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
stuggi
added a commit
to stuggi/barbican-operator
that referenced
this pull request
Sep 9, 2024
When other services deploy barbican as a dependency in CI using the barbican sample the nodeselector functionality, which was added recently with openstack-k8s-operators#153 prevents the pods from being able to be scheduled. Therefore this change will comment these optional settings. Signed-off-by: Martin Schuppert <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/barbican-operator
that referenced
this pull request
Sep 12, 2024
When other services deploy barbican as a dependency in CI using the barbican sample the nodeselector functionality, which was added recently with openstack-k8s-operators#153 prevents the pods from being able to be scheduled. Therefore this change will comment these optional settings. Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Barbican operator's code was not taking actions when the
nodeSelectorattribute was specified in the control plane. This patch addresses the missing part.