Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Add scaling down a DCN site #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krcmarik
Copy link
Contributor

@krcmarik krcmarik commented Dec 9, 2024

  • Provide an example of CR with scaled down AZ1
  • Take the control plane CR generation out to the separated step

@openshift-ci openshift-ci bot requested review from leifmadsen and raukadah December 9, 2024 13:21
@fultonj fultonj requested review from fultonj and removed request for leifmadsen and raukadah December 9, 2024 14:10
@fultonj
Copy link
Contributor

fultonj commented Dec 9, 2024

  1. Please add the following to the commit message and the PR message.
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/2591
  1. Please update the instructions in the README(s) so that it's clear how to use this new content.

One idea I have is that you could update architecture/examples/dt/dcn//dataplane-post-ceph.md to add a new section to the bottom after "Additional Availability Zones":

https://github.com/openstack-k8s-operators/architecture/blob/main/examples/dt/dcn/dataplane-post-ceph.md#additional-availability-zones

It could say something like:

This DT includes an example of how to scale down one of the deployed AZs. The example 
values in examples/dt/dcn/control-plane/scaledown/service-values.yaml have an example
of how to DTs should look when AZ1 is removed. To view them run the following command.

kustomize build architecture/examples/dt/dcn/control-plane/scaledown/

I assume the following will work based on my quick review of this PR but I haven't tried it myself.

Could you add something like the above so that someone who only has architecture repository
could use it to generate example CRs?

@krcmarik krcmarik force-pushed the dcn_scaledown branch 3 times, most recently from 8e0d33f to d517613 Compare December 11, 2024 20:14
- Provide an example of CR with scaled down AZ1
- Take the control plane CR generation out to the separated step
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krcmarik
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants