Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Octavia in uni07eta #367

Conversation

lavraham
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from cjeanner and fultonj August 12, 2024 08:57
@lavraham lavraham marked this pull request as draft August 12, 2024 08:58
@lavraham lavraham changed the title Enable Octavia in uni07eta [Draft] Enable Octavia in uni07eta Aug 12, 2024
@lavraham
Copy link
Contributor Author

We have only one test for Octavia that runs in the uni-eta job and this test passed:

[zuul@controller-0 ~]$ oc logs tempest-tests-multi-thread-testing-workflow-step-0-s42zs | grep test_active_standby_vrrp_failover
{1} octavia_tempest_plugin.tests.act_stdby_scenario.v2.test_active_standby.ActiveStandbyScenarioTest.test_active_standby_vrrp_failover [204.159158s] ... ok

@lavraham lavraham marked this pull request as ready for review September 12, 2024 12:43
@fultonj fultonj added the needs-testing Testing proof is required prior to merge label Sep 12, 2024
@fultonj
Copy link
Contributor

fultonj commented Sep 12, 2024

We have only one test for Octavia that runs in the uni-eta job and this test passed:

I see, I'm removing the needs-testing label then.

@fultonj fultonj removed the needs-testing Testing proof is required prior to merge label Sep 12, 2024
@fultonj fultonj changed the title [Draft] Enable Octavia in uni07eta Enable Octavia in uni07eta Sep 12, 2024
@fultonj
Copy link
Contributor

fultonj commented Sep 12, 2024

I'm +2 on this. It looks fine to me. I'll let another reviewer comment.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, lavraham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8f79dbd1a3bc40b0b6279770b716fc4e

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 3m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1d04233 into openstack-k8s-operators:main Sep 12, 2024
7 checks passed
@fultonj
Copy link
Contributor

fultonj commented Sep 12, 2024

lavraham pushed a commit to lavraham/architecture that referenced this pull request Sep 16, 2024
…_octavia

Enable Octavia in uni07eta

Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants