Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Commit

Permalink
Merge "Skip podman purge on Undercloud"
Browse files Browse the repository at this point in the history
  • Loading branch information
Zuul authored and openstack-gerrit committed Feb 3, 2022
2 parents e211aa0 + 7eb280a commit c4aa1e3
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
22 changes: 22 additions & 0 deletions deployment/podman/podman-baremetal-ansible.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ parameters:
additional ordering dependencies for the systemd
scopes associated to podman containers.
type: boolean
deployment_source_hosts:
default: 'Undercloud'
type: string
description: Host or hostgroup that runs the deployment

conditions:
insecure_registry_is_set:
Expand Down Expand Up @@ -217,19 +221,37 @@ outputs:
when: pcs_stat.stat.exists

post_upgrade_tasks:
# Podman purge tasks are disabled on the undercloud since the ephemeral
# Heat images need to be kept. When commit
# https://github.com/containers/podman/commit/a5ad36c65ea07d839fd9bf55a820c8cb9884eed1
# is available in the podman version used by TripleO, the ephemeral
# Heat images could be labeled in a way that they could be kept with
# --fitler, and these tasks could be re-enabled on the undercloud.
- name: Purge Podman
when:
- (step | int) == 3
- container_cli == 'podman'
- deployment_source_hosts not in group_names
include_role:
name: tripleo_podman
tasks_from: tripleo_podman_purge.yml
vars:
deployment_source_hosts: {get_param: deployment_source_hosts}

post_update_tasks:
# Podman purge tasks are disabled on the undercloud since the ephemeral
# Heat images need to be kept. When commit
# https://github.com/containers/podman/commit/a5ad36c65ea07d839fd9bf55a820c8cb9884eed1
# is available in the podman version used by TripleO, the ephemeral
# Heat images could be labeled in a way that they could be kept with
# --fitler, and these tasks could be re-enabled on the undercloud.
- name: Purge Podman
when:
- (step | int) == 3
- container_cli == 'podman'
- deployment_source_hosts not in group_names
include_role:
name: tripleo_podman
tasks_from: tripleo_podman_purge.yml
vars:
deployment_source_hosts: {get_param: deployment_source_hosts}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
other:
- |
"podman image prune" is no longer used on the undercloud to remove unused
images during the undercloud update/upgrade. With the usage of ephemeral
Heat, not all images will always be used by running or stopped containers,
so "podman image prune" should not be used to clean up the local container
image storage. Images that are no longer being used can still be removed
individually with "podman rmi".

0 comments on commit c4aa1e3

Please sign in to comment.