Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Commit

Permalink
container-puppet: update 'env' when not null
Browse files Browse the repository at this point in the history
Only update "env" if the content isn't null otherwise we'll have
container configs with:
"environment": null

And it causes problem later when we manipulate the config.

Change-Id: I0269a7ad0cf54e75dd25f8b3566ac0cab06fd93c
  • Loading branch information
EmilienM authored and mwhahaha committed Nov 7, 2019
1 parent ccf1bca commit c01f383
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions common/container-puppet.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,14 +378,11 @@ def infile_processing(infiles):
)
# When python 27 support is removed, we will be able to use:
# z = {**x, **y} to merge the dicts.
infile_data.get(
'environment',
{}
).update(
if infile_data.get('environment', None) is None:
infile_data['environment'] = {}
infile_data['environment'].update(
{'TRIPLEO_CONFIG_HASH': config_hash}
)
env = infile_data.get('environment')
infile_data['environment'] = env

outfile = os.path.join(
os.path.dirname(
Expand Down

0 comments on commit c01f383

Please sign in to comment.