Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Commit

Permalink
Remove CephHciOsdType and CephHciOsdCount parameters
Browse files Browse the repository at this point in the history
CephHciOsdType and CephHciOsdCount parameters, used only
by the deprecated derive parameters feature, should be
removed. They were missed during initial clean up.

Change-Id: Iaefc0347ac18764a683fde82075adb3067861ebf
  • Loading branch information
fultonj committed Nov 30, 2022
1 parent 0043c70 commit 4e62ae5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 32 deletions.
32 changes: 0 additions & 32 deletions deployment/cephadm/ceph-osd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,38 +38,6 @@ parameters:
type: boolean
default: false
description: Parameter used to trigger the dashboard deployment.
CephHciOsdCount:
type: number
default: 0
tags:
- role_specific
description: |
The number of expected Ceph OSDs per HCI node. Used by Ansible
module tripleo_derive_hci_parameters when cephadm/HCI is used. Since
CephOsdSpec might only specify a description of devices to be used
as OSDs (e.g. all devices), and not a list of devices as found in
CephAnsibleDisksConfig, this number is necessary in order to know
how much CPU/RAM to reserve.
CephHciOsdType:
type: string
default: 'hdd'
tags:
- role_specific
constraints:
- allowed_values: ['hdd', 'ssd', 'nvme']
description: |
CephHciOsdType is the type of data_device (not db_device) used for each
HCI node's OSD and must be one of hdd, ssd, or nvme. Used by Ansible
module tripleo_derive_hci_parameters when cephadm/HCI is used. Since
CephOsdSpec might only specify a description of devices to be used
as OSDs (e.g. all devices), and not a list of devices as found in
CephAnsibleDisksConfig, the device path is not hard coded so we cannot
look up that device in Ironic to determine its type. If CephOsdSpec
has data_devices/rotational=1 and db_devices/rotational=0, then set
CephHciOsdType to 'hdd', since only the DB/WAL are on SSD. If an OSD
data device is an SSD or NVMe SSD, then set the type accordingly so
that the derive parameters module can allocate the optimal number of
CPUs per device.

resources:
CephBase:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
deprecations:
- |
CephHciOsdType and CephHciOsdCount parameters, used by the deprecated
derive parameters feature, have been removed.

0 comments on commit 4e62ae5

Please sign in to comment.