Support actual hostnames in DeploymentServerBlacklist

Historically, we only supported heat hostnames in DeploymentServerBlacklist and this causes lots of confusion, specifically when using ephemeral heat. Let's support both. Change-Id: Ifdc0ea99e02743739d6369101eac8476f28c25b8
openstack-archive · Sep 12, 2022 · 3e41f36 · 3e41f36
1 parent f9a4495
commit 3e41f36
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/puppet/role.role.j2.yaml b/puppet/role.role.j2.yaml
@@ -133,14 +133,23 @@ parameters:
 
 conditions:
   server_blacklisted:
-    equals:
-      - {get_param: [DeploymentServerBlacklistDict, {get_param: Hostname}]}
-      - 1
+    or:
+      - equals:
+          - {get_param: [DeploymentServerBlacklistDict, {get_param: Hostname}]}
+          - 1
+      - equals:
+          - {get_param: [DeploymentServerBlacklistDict, {get_param: [HostnameMap, {get_param: Hostname}]}]}
+          - 1
   server_not_blacklisted:
-    not:
-      equals:
-        - {get_param: [DeploymentServerBlacklistDict, {get_param: Hostname}]}
-        - 1
+    and:
+      - not:
+          equals:
+            - {get_param: [DeploymentServerBlacklistDict, {get_param: Hostname}]}
+            - 1
+      - not:
+          equals:
+            - {get_param: [DeploymentServerBlacklistDict, {get_param: [HostnameMap, {get_param: Hostname}]}]}
+            - 1
   ctlplane_fixed_ip_set:
     or:
       - not:

diff --git a/releasenotes/notes/support-hostname-deployment-server-blacklist-532221db0e7d2bef.yaml b/releasenotes/notes/support-hostname-deployment-server-blacklist-532221db0e7d2bef.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    DeploymentServerBlacklist parameter now supports both
+    heat and actual hostnames.