Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm From<OwnedFd> for Stdio impl #82

Merged
merged 1 commit into from
Jun 19, 2022
+0 −6
Merged

Rm From<OwnedFd> for Stdio impl #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rm From<OwnedFd> for Stdio impl 
to avoid using `io_lifetimes` in public API.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
NobodyXu committed Jun 14, 2022
commit c7867ba4b5613d459b4cabb0c4e5171049905135
6 changes: 0 additions & 6 deletions src/stdio.rs
View file
Original file line number Diff line number Diff line change
@@ -75,12 +75,6 @@ impl From<Stdio> for process::Stdio {
}
}

impl From<OwnedFd> for Stdio {
fn from(fd: OwnedFd) -> Self {
Self(StdioImpl::Fd(fd))
}
}

macro_rules! impl_from_for_stdio {
($type:ty) => {
impl From<$type> for Stdio {