Enhancement of OptiBP widget to add Calibration data #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubdabasoduba
requested changes
Aug 2, 2022
| public static final String DATE = "date"; | ||
| public static final String VERSION = "version"; | ||
| public static final String MODEL = "model"; | ||
| public static final String HEIGHT = "height"; | ||
| public static final String WEIGHT = "weight"; | ||
| public static final String COMPERATIVES = "comperatives"; | ||
| public static final String SYSTOLIC = "systolic"; |
There was a problem hiding this comment.
@SebaMutuku Are we removing this because we no longer need it?
| JSONObject calibrationJson = new JSONObject(); | ||
| JSONObject comparativesJson = new JSONObject(); | ||
| calibrationJson.put(OPTIBPCONSTANTS.DATE, df.format(new Date())); | ||
| calibrationJson.put(OPTIBPCONSTANTS.VERSION, 1); |
There was a problem hiding this comment.
@SebaMutuku We agreed to remove this since the OptiBP app creates its
| @@ -430,7 +415,7 @@ private void attachRefreshLogic(Context context, JSONObject jsonObject, View vie | |||
| } | |||
| } | |||
|
|
|||
| protected enum BPFieldType { | |||
| protected enum BPFieldType { | |||
There was a problem hiding this comment.
Use camel case naming standard
| @@ -376,7 +377,7 @@ public void testInputJson() throws JSONException { | |||
| Mockito.doReturn(jsonApi).when(formFragment).getJsonApi(); | |||
| Mockito.doReturn(new JSONObject(formString)).when(jsonApi).getmJSONObject(); | |||
|
|
|||
| String inputJson = factorySpy.getInputJsonString(jsonFormActivity, new JSONObject(optiBPWidgetString), widgetArgs); | |||
| String inputJson = factorySpy.getInputJsonString(RuntimeEnvironment.application.getApplicationContext(), new JSONObject(optiBPWidgetString), widgetArgs); | |||
There was a problem hiding this comment.
Why are we changing this from using the Activity context
dubdabasoduba
requested changes
Aug 24, 2022
There was a problem hiding this comment.
@SebaMutuku Please fix all the code quality issues reported by codacy
Base automatically changed from
feature/translate_radio_button_values
to
master
September 26, 2022 08:56
# Conflicts: # gradle.properties
SebaMutuku
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.