Update opensrp-web express csp policy vars #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterMuriuki
force-pushed
the
add-default-nginx-ingress-headers
branch
from
9292e61 to
3ba1d2e
Compare
peterMuriuki
changed the title
peterMuriuki
force-pushed
the
add-default-nginx-ingress-headers
branch
2 times, most recently
from
f7d4055 to
df0fd27
Compare
peterMuriuki
changed the title
peterMuriuki
commented
Apr 28, 2022
bennsimon
requested changes
May 5, 2022
peterMuriuki
force-pushed
the
add-default-nginx-ingress-headers
branch
from
26bf2f4 to
d4e9390
Compare
peterMuriuki
changed the title
bennsimon
requested changes
May 9, 2022
bennsimon
requested changes
May 9, 2022
charts/opensrp-web/values.yaml
Outdated
| @@ -186,6 +187,21 @@ express: | |||
| sessionPath: "/" | |||
| reactBuildPath: "/usr/src/web" | |||
| nodeEnv: "production" | |||
| csp: | |||
| report-uri: "https://{{ .Values.sentry.domain }}/api/{{ .Values.sentry.projectId }}/security/?sentry_key={{ .Values.sentry.sentryKey }}&sentry_environment={{ .Values.sentry.environment }}&sentry_release={{ .Release.Name }}" | |||
There was a problem hiding this comment.
Kindly add checks that this wont fail but default to something if sentry configs are not supplied.
bennsimon
requested changes
May 9, 2022
Can add other headers here like support for report-to
…p/helm-charts into add-default-nginx-ingress-headers
update chart minor version, remove csp policy for jquery
machariamuguku
approved these changes
Jul 7, 2022
bennsimon
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CSP directives to express envs
Adds configs for this onaio/express-server#30