-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide authentication support via Keycloak #1
Conversation
README.md
Outdated
@@ -0,0 +1,3 @@ | |||
# Opensrp Server FHIR Security Auth | |||
|
|||
This repo consists of providing Authentication support via Keycloak. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change to something like this.
This repository provides spring security authentication configuration through Keycloak authorisation servers
- Create an issue to update the README or update docs on how the module and specific keycloak configs are to be added - I don't think this is technical debt. Good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated @ekigamba . Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2
Here is the issue for the documentation.
@Override | ||
protected void configure(HttpSecurity http) throws Exception { | ||
super.configure(http); | ||
logger.error("Inside configure method"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to logger.info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
opensrp/fhircore#40