Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FHIR SDC and FHIR Engine #3699

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Migrate FHIR SDC and FHIR Engine #3699

merged 1 commit into from
Jan 22, 2025

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

FHIR SDK Upgrade

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS enabled auto-merge January 22, 2025 09:23
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.5%. Comparing base (61f68b1) to head (d8dd759).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3699   +/-   ##
=======================================
  Coverage     38.5%   38.5%           
  Complexity    1164    1164           
=======================================
  Files          286     286           
  Lines        15232   15232           
  Branches      2683    2683           
=======================================
  Hits          5866    5866           
  Misses        8521    8521           
  Partials       845     845           
Flag Coverage Δ
engine 62.5% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 24.6% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@LZRS LZRS added this pull request to the merge queue Jan 22, 2025
@ndegwamartin ndegwamartin removed this pull request from the merge queue due to a manual request Jan 22, 2025
@ndegwamartin ndegwamartin merged commit 2fe2be1 into main Jan 22, 2025
5 checks passed
@ndegwamartin ndegwamartin deleted the migrate-engine-sdc branch January 22, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants