-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling sync status by harmonizing SDK and custom sync statuses #3650
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! can you please cover the new code paths with tests, thank you!
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
…nto harmonize-sync-status Signed-off-by: Elly Kitoto <[email protected]>
Harmonize custom resource and app sync. Each sync is identified by a counter. The max sync count is 2. Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
@HenryRae Can you review this? For context, we are trying to harmonize the sync UI. For EUSM we run 2 kinds of sync. The first sync downloads the location hierarchy and the second downloads/uploads user data. Right now, it's technically easier to separate the sync processes and observe their states independently. The first sync needs to be completed before the second sync is started. We need a way to notify the user when any syncs are running. For now, we show progress and success/failure for both as seen in the screenshots. |
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
…nto harmonize-sync-status
@ellykits This is okay, we can show the second progress 3-5 seconds after the first sync success message |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3687
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file