-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement event management to close custom resources via the backgrond Worker #3483
Conversation
…nd worker. Signed-off-by: Lentumunai-Mark <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3483 +/- ##
=========================================
- Coverage 27.2% 27.2% -0.1%
- Complexity 742 749 +7
=========================================
Files 276 275 -1
Lines 13811 13940 +129
Branches 2504 2532 +28
=========================================
+ Hits 3764 3794 +30
- Misses 9540 9622 +82
- Partials 507 524 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
Signed-off-by: Lentumunai-Mark <[email protected]>
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceExpireWorker.kt
Outdated
Show resolved
Hide resolved
android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceUtil.kt
Outdated
Show resolved
Hide resolved
…/task/FhirResourceExpireWorker.kt Co-authored-by: Elly Kitoto <[email protected]>
…/task/FhirResourceUtil.kt Co-authored-by: Elly Kitoto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marklosh Please update the event management documentation to reflect what you have done. Also, does this mean the team target service requests should update their confirms
Signed-off-by: Lentumunai-Mark <[email protected]>
This is unnecessary. |
…d Worker (#3483) * Implement event management to close custom resources via the background worker. Signed-off-by: Lentumunai-Mark <[email protected]> * "Start writing test fro closing custom resources" Signed-off-by: Lentumunai-Mark <[email protected]> * Test closure of resources without a base resource. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Update android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceExpireWorker.kt Co-authored-by: Elly Kitoto <[email protected]> * Update android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceUtil.kt Co-authored-by: Elly Kitoto <[email protected]> * Replace old fucntion name with new function name. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Elly Kitoto <[email protected]>
…d Worker (opensrp#3483) * Implement event management to close custom resources via the background worker. Signed-off-by: Lentumunai-Mark <[email protected]> * "Start writing test fro closing custom resources" Signed-off-by: Lentumunai-Mark <[email protected]> * Test closure of resources without a base resource. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Update android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceExpireWorker.kt Co-authored-by: Elly Kitoto <[email protected]> * Update android/engine/src/main/java/org/smartregister/fhircore/engine/task/FhirResourceUtil.kt Co-authored-by: Elly Kitoto <[email protected]> * Replace old fucntion name with new function name. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> (cherry picked from commit 2601cd0)
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3482
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file