Use subject's Related Entity Location meta tag on related resources #3097

ellykits · 2024-02-23T14:02:19Z

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3077

Engineer Checklist

I have written Unit tests for any new feature(s) and edge cases for bug fixes
I have added any strings visible on UI components to the strings.xml file
I have updated the CHANGELOG.md file for any notable changes to the codebase
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

I have verified Unit tests have been written for any new feature(s) and edge cases
I have verified any strings visible on UI components are in the strings.xml file
I have verifed the CHANGELOG.md file has any notable changes to the codebase
I have verified the solution has been implemented in a configurable and generic way for reuseable components
I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Elly Kitoto <[email protected]>

codecov · 2024-02-23T14:26:32Z

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 29.8%. Comparing base (ad3a737) to head (2e9bced).
Report is 184 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3097      +/-   ##
==========================================
- Coverage     64.5%   29.8%   -34.7%     
+ Complexity    1075     652     -423     
==========================================
  Files          218     236      +18     
  Lines         9635   11074    +1439     
  Branches      1897    1928      +31     
==========================================
- Hits          6218    3306    -2912     
- Misses        2234    7338    +5104     
+ Partials      1183     430     -753

Flag	Coverage Δ
engine	`66.2% <ø> (-6.5%)`	⬇️
geowidget	`47.2% <ø> (-17.1%)`	⬇️
quest	`5.2% <0.0%> (-53.7%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt	`3.3% <0.0%> (-69.8%)`	⬇️

... and 126 files with indirect coverage changes

Signed-off-by: Elly Kitoto <[email protected]>

dubdabasoduba · 2024-02-25T14:25:53Z

...st/src/main/java/org/smartregister/fhircore/quest/ui/questionnaire/QuestionnaireViewModel.kt

+    subjectType: ResourceType?,
  ) {
-    questionnaireConfig.groupResource?.let {
-      if (it.groupIdentifier.isNotEmpty() && !it.removeGroup && !it.removeMember) {
-        val group =
-          loadResource(
-            ResourceType.Group,
-            it.groupIdentifier.extractLogicalIdUuid(),
-          )
-            as Group?
-        if (group != null) {
-          val system =
-            context.getString(
-              org.smartregister.fhircore.engine.R.string
-                .sync_strategy_related_entity_location_system,
-            )
-          group.meta.tag.filter { coding -> coding.system == system }.forEach(this.meta::addTag)
+    val resourceIdPair =
+      when {
+        !questionnaireConfig.resourceIdentifier.isNullOrEmpty() && subjectType != null -> {
+          Pair(subjectType, questionnaireConfig.resourceIdentifier!!)
+        }
+        !questionnaireConfig.groupResource?.groupIdentifier.isNullOrEmpty() &&
+          questionnaireConfig.groupResource?.removeGroup != true &&
+          questionnaireConfig.groupResource?.removeMember != true -> {
+          Pair(ResourceType.Group, questionnaireConfig.groupResource!!.groupIdentifier)
        }
+        else -> null
+      }
+    if (resourceIdPair != null) {
+      val (resourceType, resourceId) = resourceIdPair
+      val group =
+        loadResource(resourceType = resourceType, resourceIdentifier = resourceId) as Group?
+      if (group != null) {
+        val system =
+          context.getString(
+            org.smartregister.fhircore.engine.R.string.sync_strategy_related_entity_location_system,
+          )
+        group.meta.tag.filter { coding -> coding.system == system }.forEach(this.meta::addTag)
      }


@ellykits how do we handle the situation where we do not want to propagate the Group REL (Related Entity location) to the patient resources?

The Group's REL only propagates if the Questionnaire has a groupResource (should only happen when adding Group member) config. If we do not want to propagate the group's REL two options:

Do not configure groupResource on resource

Provide configurations for extracting location ID from QuestionnaireResponse when launching the questionnaire. The location ID will be used on the subject and related resources extracted from the questionnaire submission. (To be used when you want the configured locationId to override the subject's)

The subject resource's REL is given precedence over the Group's REL because, if the subject were added as a member of the Group it would have the Group's REL anyway.

@ellykits I assume point 2 is going to handle the situation where a Familly member does not leave in the same place as the rest of the family, right ?

Yes, that's correct.

…fhircore into fix-set-related-entity-location Signed-off-by: Elly Kitoto <[email protected]>

Signed-off-by: Elly Kitoto <[email protected]>

f-odhiambo

Resource are adding Tags as expected

ndegwamartin · 2024-02-26T14:37:40Z

@ellykits merging this and creating a separate issue for the unit tests for this update.

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

…3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]>

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

@ignore

…#3107) * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Update tests WIP Signed-off-by: Lentumunai-Mark <[email protected]> * Use subject's Related Entity Location meta tag on related resources (#3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> * eir demo flavor (#3102) * update admin-dashboard-feature docs (#3084) Co-authored-by: Benjamin Mwalimu <[email protected]> * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Resolve conflicts Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Add deny permission for UI automator Signed-off-by: Lentumunai-Mark <[email protected]> * Grant permission on tests where required. Signed-off-by: Lentumunai-Mark <[email protected]> * Remove unused functions. Signed-off-by: Lentumunai-Mark <[email protected]> * rename function to be more descriptive. Signed-off-by: Lentumunai-Mark <[email protected]> * Adress PR feedback provided. Signed-off-by: Lentumunai-Mark <[email protected]> * Format files changed by running spotlessApply Signed-off-by: Lentumunai-Mark <[email protected]> * Update application config to remove outdated variables * Use data store on Location service Signed-off-by: Lentumunai-Mark <[email protected]> * Change grant permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Change how we're accessing permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless check. Signed-off-by: Lentumunai-Mark <[email protected]> * Try resolve failing test. Signed-off-by: Lentumunai-Mark <[email protected]> * Add permission granted rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Add @ignore to the failing tests Signed-off-by: Lentumunai-Mark <[email protected]> * Test commit, trying out new CI fixes. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Update AppMainActivityTest.kt * Fix spotless check failing. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> Co-authored-by: Roy <[email protected]> Co-authored-by: Owais <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]>

@ignore

* Add Internationalization documentation 📝 (#3221) * Add Internationalization documentation 📝 * Disable autobackup - not recommended * Pin Mac OS runner version to previous stable version | Fix build 💚 * Remove init block blocking thrown errors (#3231) * Interpolate image visible property (#3234) * Configs Versioning (#3189) * Configs versioning setup * init implementation guide version in settings screen * remove unused tag * add string resource * fetch composition referenced in IG * add implementationguide to test * Add ImplementationGuide resource * update tests * Update implementation_guide_config.json * Refactor flow * Rename implementationGuideUrl to implementationGuideId - Code cleanup * Format implementation_guide_config.json * Run spotlessApply * Remove implementationGuideId entry from app config - Add name field to IG config - Update variable name * Refactor implementation from config registry * refactor to use IG by version * Run spotlessApply * Refactors and bug fixes * Update sample ImplementationGuide URL and version * Update fetchRemoteIG app URL * Remove flavour from versionName when fetching IG * Save IG after fetch * save ImplementationGuide to database * introduce fetchConfiguration IG test skeletons * Update IG URL to FQDN * find and sort IG by context-quantity * fix failing tests * update IG tests * use implmentaionGuide extension guide * use version code for context-quantity * empty commit to trigger checks * run spotlessApply * remove unnecessary implementationGuide details from userSettingsScreen * spotlessApply * initiate Implementation Guide documentation * Update strings.xml Co-authored-by: Peter Lubell-Doughtie <[email protected]> --------- Co-authored-by: Simon Njoroge <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> * Fix questionnaire prepopulation using initialExpression (#3240) * Implement searchable multiselect widget (#3123) * Implement multiselectview Start implementation on multi-select view. Includes the checkbox and listeners Signed-off-by: Elly Kitoto <[email protected]> * Change preview data Signed-off-by: Elly Kitoto <[email protected]> * Use TristateCheckbox on MultiSelect view Signed-off-by: Elly Kitoto <[email protected]> * Implement functionality for generating map required in multiselectview Signed-off-by: Elly Kitoto <[email protected]> * Implement bottomsheet for multi select widget Signed-off-by: Elly Kitoto <[email protected]> * Fix multi-select checkbox select color Signed-off-by: Elly Kitoto <[email protected]> * Implement functionality for node selection Signed-off-by: Elly Kitoto <[email protected]> * Refactor multi select implementation Use Tree data structure as required. Search Tree instead of searching the map. Render the UI from the Tree. Signed-off-by: Elly Kitoto <[email protected]> * Improve UX on multi selector widget search Hide keyboard when search action is triggered. Reset data when search text is empty. Signed-off-by: Elly Kitoto <[email protected]> * Refactor MultiSelect UI to use Compose Scaffold Signed-off-by: Elly Kitoto <[email protected]> * Use ProtoDataStore to store SyncLocations Also refactored how root nodes are identified. Use configuration instead of defaulting to a node without a parent node as the root node. Signed-off-by: Elly Kitoto <[email protected]> * Use selected locations from multi-select widget to sync resources Add comma separated values for _syncLocations query parameter for all requests for the configured sync Resources. Signed-off-by: Elly Kitoto <[email protected]> * Refactor ApplicationConfiguration.syncStrategies to syncStrategy Signed-off-by: Elly Kitoto <[email protected]> * Fix child node checked state issue * Show progress dialog * Add no results view * Refactor initial sync logic + disable sync progresss dialog * Disable progress dialog on initial sync * Fix spotless formatting errors * Add Practitioner to SyncStrategy * Fix failing tests Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> * Change questionnaire button styling (#3244) * [Build Variant] ECD App (#3222) * Initial Commit * Add custom view holder for choice input type password in Questionnaire * Add ECD Hack config * Update constants to one place * Remove ECDHack app variant --------- Co-authored-by: mapratama <[email protected]> Co-authored-by: Sebastian <[email protected]> Co-authored-by: SebaMutuku <[email protected]> * Bump express from 4.18.2 to 4.19.2 (#3182) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Implement feature to compute distance between two locations via Rules (#3107) * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Update tests WIP Signed-off-by: Lentumunai-Mark <[email protected]> * Use subject's Related Entity Location meta tag on related resources (#3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> * eir demo flavor (#3102) * update admin-dashboard-feature docs (#3084) Co-authored-by: Benjamin Mwalimu <[email protected]> * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Resolve conflicts Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Add deny permission for UI automator Signed-off-by: Lentumunai-Mark <[email protected]> * Grant permission on tests where required. Signed-off-by: Lentumunai-Mark <[email protected]> * Remove unused functions. Signed-off-by: Lentumunai-Mark <[email protected]> * rename function to be more descriptive. Signed-off-by: Lentumunai-Mark <[email protected]> * Adress PR feedback provided. Signed-off-by: Lentumunai-Mark <[email protected]> * Format files changed by running spotlessApply Signed-off-by: Lentumunai-Mark <[email protected]> * Update application config to remove outdated variables * Use data store on Location service Signed-off-by: Lentumunai-Mark <[email protected]> * Change grant permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Change how we're accessing permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless check. Signed-off-by: Lentumunai-Mark <[email protected]> * Try resolve failing test. Signed-off-by: Lentumunai-Mark <[email protected]> * Add permission granted rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Add @ignore to the failing tests Signed-off-by: Lentumunai-Mark <[email protected]> * Test commit, trying out new CI fixes. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Update AppMainActivityTest.kt * Fix spotless check failing. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> Co-authored-by: Roy <[email protected]> Co-authored-by: Owais <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> * Enhance Insight Screen UX (#3195) * swap app and assignment info * update tests * edit insights screen * edit insights screen * edit insights screen * edit insights screen * remove null username * cater for empty parameters * Enhance UI Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Martin Ndegwa <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> * added new property in service-card configs to control the status-icon-size on register screen (#3219) Co-authored-by: owais-vd <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> * Fix remove household (#3262) Co-authored-by: Aleem Azhar <[email protected]> * Fix disable edit fields not working (#3247) * Remove unanswered linkId from questionnaireResponse so that default initial values for the linkId get picked from Questionnaire * Apply patch changes from #3218 * Migrate Knowledge and Workflow SDK library versions (#3266) * Update Code release process documentation * Migrate Knowledge and Workflow SDK library versions * Docs for P2P Sync (#3192) * Docs for P2P Sync * Update image correctly * Update formatting * cleanup text and fix image location * Add links to references * Update p2p documentation --------- Co-authored-by: pld <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Francis Odhiambo <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> * Fix sort and filter issues (#3254) * Activate sorting for related resources Signed-off-by: Elly Kitoto <[email protected]> * Remove material3 dependencies Signed-off-by: Elly Kitoto <[email protected]> * Use all the provided register filter criteria Previously only the filter criteria that were updated by content from the Questionnaire fields were used. Signed-off-by: Elly Kitoto <[email protected]> * Set questionnaire submit button text via configuration Signed-off-by: Elly Kitoto <[email protected]> * Implement clear all action on register filter questionnaire Signed-off-by: Elly Kitoto <[email protected]> * Add more assertion on register filter data queries test Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> * Fix filtering by integer * Activate sorting for related resources Signed-off-by: Elly Kitoto <[email protected]> * Remove material3 dependencies Signed-off-by: Elly Kitoto <[email protected]> * Use all the provided register filter criteria Previously only the filter criteria that were updated by content from the Questionnaire fields were used. Signed-off-by: Elly Kitoto <[email protected]> * Set questionnaire submit button text via configuration Signed-off-by: Elly Kitoto <[email protected]> * Implement clear all action on register filter questionnaire Signed-off-by: Elly Kitoto <[email protected]> * Add more assertion on register filter data queries test Signed-off-by: Elly Kitoto <[email protected]> * Fix filter by number Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> * Add Encounter Participant to TransformSupportServices * added structure-defnition resource-type in ConfigurationRegistry * 🐛 [WIP] Adding the value set resolver --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: L≡ZRS <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Hilary Baraka Egesa <[email protected]> Co-authored-by: Simon Njoroge <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Francis Odhiambo <[email protected]> Co-authored-by: mapratama <[email protected]> Co-authored-by: Sebastian <[email protected]> Co-authored-by: SebaMutuku <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Roy <[email protected]> Co-authored-by: Owais <[email protected]> Co-authored-by: Rachel Murabula <[email protected]> Co-authored-by: Syed Owais Ali <[email protected]> Co-authored-by: owais-vd <[email protected]> Co-authored-by: Aleem Azhar <[email protected]>

…3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]>

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

@ignore

…#3107) * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Update tests WIP Signed-off-by: Lentumunai-Mark <[email protected]> * Use subject's Related Entity Location meta tag on related resources (#3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> * eir demo flavor (#3102) * update admin-dashboard-feature docs (#3084) Co-authored-by: Benjamin Mwalimu <[email protected]> * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <[email protected]> * Resolve conflicts Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <[email protected]> * Add deny permission for UI automator Signed-off-by: Lentumunai-Mark <[email protected]> * Grant permission on tests where required. Signed-off-by: Lentumunai-Mark <[email protected]> * Remove unused functions. Signed-off-by: Lentumunai-Mark <[email protected]> * rename function to be more descriptive. Signed-off-by: Lentumunai-Mark <[email protected]> * Adress PR feedback provided. Signed-off-by: Lentumunai-Mark <[email protected]> * Format files changed by running spotlessApply Signed-off-by: Lentumunai-Mark <[email protected]> * Update application config to remove outdated variables * Use data store on Location service Signed-off-by: Lentumunai-Mark <[email protected]> * Change grant permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Change how we're accessing permission rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Run spotless check. Signed-off-by: Lentumunai-Mark <[email protected]> * Try resolve failing test. Signed-off-by: Lentumunai-Mark <[email protected]> * Add permission granted rule. Signed-off-by: Lentumunai-Mark <[email protected]> * Add @ignore to the failing tests Signed-off-by: Lentumunai-Mark <[email protected]> * Test commit, trying out new CI fixes. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix spotless check Signed-off-by: Lentumunai-Mark <[email protected]> * Update AppMainActivityTest.kt * Fix spotless check failing. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: pld <[email protected]> Co-authored-by: Roy <[email protected]> Co-authored-by: Owais <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]>

Use subject's Related Entity Location meta tag on related resources

989b9eb

Signed-off-by: Elly Kitoto <[email protected]>

pld previously approved these changes Feb 23, 2024

View reviewed changes

pld dismissed their stale review via 01e39fb February 23, 2024 17:17

pld previously approved these changes Feb 23, 2024

View reviewed changes

ellykits and others added 2 commits February 23, 2024 12:36

Use subject's Related Entity Location meta tag on related resources

25e74ab

Signed-off-by: Elly Kitoto <[email protected]>

update spotless

70c0be4

pld force-pushed the fix-set-related-entity-location branch from 01e39fb to 70c0be4 Compare February 23, 2024 17:37

dubdabasoduba requested changes Feb 25, 2024

View reviewed changes

ellykits added 2 commits February 26, 2024 10:55

Merge branch 'fix-set-related-entity-location' of github.com:opensrp/…

d4d3c48

…fhircore into fix-set-related-entity-location Signed-off-by: Elly Kitoto <[email protected]>

Fix failing test

2e9bced

Signed-off-by: Elly Kitoto <[email protected]>

ellykits dismissed pld’s stale review via 2e9bced February 26, 2024 08:14

f-odhiambo self-requested a review February 26, 2024 09:23

f-odhiambo approved these changes Feb 26, 2024

View reviewed changes

dubdabasoduba self-requested a review February 26, 2024 14:35

dubdabasoduba approved these changes Feb 26, 2024

View reviewed changes

ndegwamartin merged commit 2785261 into main Feb 26, 2024
4 of 5 checks passed

ndegwamartin deleted the fix-set-related-entity-location branch February 26, 2024 14:38

ndegwamartin mentioned this pull request Feb 26, 2024

Write Unit Tests on Related Entity Location sync strategy enchancements #3105

Closed

AbdulWahabMemon added a commit that referenced this pull request Feb 26, 2024

Merge branch 'main' into main-lw-sample

bf078ca

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

AbdulWahabMemon added a commit that referenced this pull request Feb 28, 2024

Merge branch 'main' into hh-reg-location-picker-tests

7ccfb95

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

ellykits mentioned this pull request Mar 19, 2024

Write Unit Tests on Related Entity Location sync strategy enchancements #3144

Merged

11 tasks

qiarie pushed a commit that referenced this pull request Jan 15, 2025

Merge branch 'main' into main-lw-sample

4aece3b

* main: update admin-dashboard-feature docs (#3084) eir demo flavor (#3102) Use subject's Related Entity Location meta tag on related resources (#3097)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use subject's Related Entity Location meta tag on related resources #3097

Use subject's Related Entity Location meta tag on related resources #3097

ellykits commented Feb 23, 2024 •

edited

Loading

codecov bot commented Feb 23, 2024 •

edited

Loading

dubdabasoduba Feb 25, 2024

ellykits Feb 26, 2024

dubdabasoduba Feb 26, 2024

ellykits Feb 26, 2024 •

edited

Loading

f-odhiambo left a comment

ndegwamartin commented Feb 26, 2024

Use subject's Related Entity Location meta tag on related resources #3097

Use subject's Related Entity Location meta tag on related resources #3097

Conversation

ellykits commented Feb 23, 2024 • edited Loading

codecov bot commented Feb 23, 2024 • edited Loading

Codecov Report

dubdabasoduba Feb 25, 2024

Choose a reason for hiding this comment

ellykits Feb 26, 2024

Choose a reason for hiding this comment

dubdabasoduba Feb 26, 2024

Choose a reason for hiding this comment

ellykits Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

f-odhiambo left a comment

Choose a reason for hiding this comment

ndegwamartin commented Feb 26, 2024

ellykits commented Feb 23, 2024 •

edited

Loading

codecov bot commented Feb 23, 2024 •

edited

Loading

ellykits Feb 26, 2024 •

edited

Loading