-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch PractitionerId, PractitionerLocation, PractitionerCareTeam, PractitionerOrganization from Shared Preferences #2903
Conversation
…ractitionerOrganization * Create new enum class called PractitionerKey * Create a function called extractSharedPrefValues in RulesFactory
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
=========================================
+ Coverage 64.5% 66.7% +2.2%
- Complexity 1075 1091 +16
=========================================
Files 218 222 +4
Lines 9635 10187 +552
Branches 1897 1881 -16
=========================================
+ Hits 6218 6803 +585
+ Misses 2234 2193 -41
- Partials 1183 1191 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…p/fhircore into fetch-assignment-data-using-rules
…p/fhircore into fetch-assignment-data-using-rules
…p/fhircore into fetch-assignment-data-using-rules
…p/fhircore into fetch-assignment-data-using-rules
@Raynafs it would be nice if you added documentation on how to use this particular rule |
Yes sure. Working on it. |
@Rkareko @SebaMutuku I have written the docs now. Thanks |
|
||
## Using the `extractPractitionerInfoFromSharedPrefs()` rule | ||
|
||
This rule is used within the rules engine or workflow to extract `PractitionerId`, `PractitionerCareTeam`, `PractitionerOrganization` and `PractitionerLocation` from `Shared Preference`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List all the enums that are supported by this change e.g in order to fetch PractitionerId
which enum would be used?
A tabular format would be easy to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I have done so
…p/fhircore into fetch-assignment-data-using-rules
@SebaMutuku all the checks have passed. |
…ctitionerOrganization from Shared Preferences (#2903) * Extract PractitionerId, PractitionerLocation, PractitionerCareTeam, PractitionerOrganization * Create new enum class called PractitionerKey * Create a function called extractSharedPrefValues in RulesFactory * Fix spacing and code check * Change few files * Fix first failing test * Add Practitioner Tests and rule tests in household config * Fix failing engine tests * Add Practitioner Tests and rule tests in household config * Fix test view * provide documentation on how to use extractPractitionerInfoFromSharedPrefs() rule * Write tabular representation of enums and their infos * Fix test issue * run spotless --------- Co-authored-by: Sebastian <[email protected]> Co-authored-by: SebaMutuku <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]>
Extract PractitionerId, PractitionerLocation, PractitionerCareTeam, PractitionerOrganization
* Create new enum class called PractitionerKey
* Create a function called extractSharedPrefValues in RulesFactory
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2900
Depends on PR #2873 (Which saves practitioner details on shared preferences)
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file