-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF] Enhance performance partition change rate #958
Merged
harryteng9527
merged 7 commits into
opensource4you:main
from
harryteng9527:enhance-performance-partition-variance-ratio
Oct 21, 2022
Merged
[PERF] Enhance performance partition change rate #958
harryteng9527
merged 7 commits into
opensource4you:main
from
harryteng9527:enhance-performance-partition-variance-ratio
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harryteng9527 感謝更新,幾個建議請看一下
app/src/main/java/org/astraea/app/performance/PartitionRatioListener.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/performance/TrackerThread.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/app/performance/PartitionRatioListener.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 20, 2022
chia7712
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如 #689 (comment) 所討論,先為 Performance tool 新增紀錄 assigned partitions 變化率的功能