Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the package name of metrics #80

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Optimize the package name of metrics #80

merged 1 commit into from
Oct 28, 2021

Conversation

chia7712
Copy link
Contributor

避免出現org.astraea.metrics.kafka.metrics這種重複名字的package path

@chia7712 chia7712 requested a review from garyparrot October 28, 2021 12:06
@chia7712 chia7712 self-assigned this Oct 28, 2021
garyparrot
garyparrot approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@garyparrot garyparrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chia7712 chia7712 merged commit 6a8d1db into opensource4you:main Oct 28, 2021
@chia7712 chia7712 deleted the rename_package branch December 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyparrot garyparrot garyparrot approved these changes

Assignees

@chia7712 chia7712

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chia7712 @garyparrot