Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broker disk space cost #1604

Merged
merged 18 commits into from
May 17, 2023

Conversation

qoo332001
Copy link
Collaborator

新增BrokerDiskSpaceCost來限制搬移過程中最多會佔用的broker/data path空間

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝實作新功能,幾個建議請看一下

@qoo332001
Copy link
Collaborator Author

@chia7712 做了一些更新,麻煩在看一次,謝謝

@qoo332001 qoo332001 requested a review from chia7712 March 31, 2023 15:15
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝快速的修正,還有幾個建議請看一下

@qoo332001 qoo332001 requested a review from chia7712 April 9, 2023 14:19
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝功能和修正,請再看一下 cluster info 中有哪些方法要移動到 costutils

另外可否開一隻議題來展示一下這個功能?並且在隨後寫成一個簡單的報告發成PR

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝更新功能,幾個建議請再看一下

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

麻煩合併完後再重新跑一次 #1689,然後我們在那邊討論後續

@qoo332001 qoo332001 merged commit 47bb2ce into opensource4you:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants