-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broker disk space cost #1604
Add broker disk space cost #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 感謝實作新功能,幾個建議請看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
…rokerDiskSpaceCost
@chia7712 做了一些更新,麻煩在看一次,謝謝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 感謝快速的修正,還有幾個建議請看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
…rokerDiskSpaceCost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 感謝功能和修正,請再看一下 cluster info 中有哪些方法要移動到 costutils
另外可否開一隻議題來展示一下這個功能?並且在隨後寫成一個簡單的報告發成PR
…rokerDiskSpaceCost
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qoo332001 感謝更新功能,幾個建議請再看一下
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/BrokerDiskSpaceCost.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
麻煩合併完後再重新跑一次 #1689,然後我們在那邊討論後續
新增
BrokerDiskSpaceCost
來限制搬移過程中最多會佔用的broker/data path空間