[METRICS] Append worker metrics #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Feb 19, 2023
|
|
||
| import org.astraea.common.metrics.HasBeanObject; | ||
|
|
||
| public interface HasAdminMetrics extends HasBeanObject { | ||
| @FunctionalInterface | ||
| public interface HasSelectorMetrics extends HasBeanObject { |
There was a problem hiding this comment.
這個設計不錯，不過可否加上註解說明一下是對應 kafka 底層的 selector，那個元件並不是公開的元件，稍微說明一下以免誤會
chia7712
reviewed
Feb 19, 2023
| default String clientId() { | ||
| return beanObject().properties().get("client-id"); | ||
| } | ||
| public interface HasConsumerCoordinatorMetrics extends HasCoordinatorMetrics { |
There was a problem hiding this comment.
這個設計也很好，可以考慮把@FunctionalInterface都加上去，可以預防我們不小心改錯
chia7712
reviewed
Feb 19, 2023
|
@chaohengstudent 感謝這次的patch，做得很好。後續我們要將其新增到 https://github.com/skiptests/astraea/blob/main/gui/src/main/java/org/astraea/gui/tab/ConnectorNode.java 可否協助完成？這樣使用者可以透過GUI更方便的觀察 worker 運行狀況 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1496
新增 "kafka.connect" metrics
app-infoconnect-coordinator-metricsconnect-metricsconnect-node-metricsconnect-worker-metricsconnect-worker-rebalance-metricsconnector-metricsrename file
ConnectorInfotoConnectorTaskInfo(connector-task-metrics) 因為將新增的 connector-metrics 命名為前者新增
HasCoordinatorMetrics-> 將 consumer 及 connector 的 coordinator 合併共同 metrics新增
HasSelectorMetrics-> admin, consumer, producer, connector -metrics 合併共同 metrics新增測試
ConnectorMetricsTest