New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COST] make sure all brokers have cost #1456

Merged

chia7712 merged 2 commits into opensource4you:main from chia7712:make_all_brokers_has_cost

Jan 23, 2023

Contributor

chia7712 commented Jan 23, 2023

基於node的成本會在節點沒有對應指標時回傳“空”的成本，這會導致該節點無法被納入評估，因此這隻PR賦予所有“沒有指標”的節點最基本的分數 - max cost，代表該些節點也應該被考慮，但不是最佳優先


          [COST] make sure all brokers have cost

f74b72f

chia7712 commented

View reviewed changes

common/src/main/java/org/astraea/common/admin/ClusterBean.java

@@ @@ -32,7 +31,7 @@ @@
               public interface ClusterBean {
                 ClusterBean EMPTY = ClusterBean.of(Map.of());
-                static ClusterBean of(Map<Integer, Collection<HasBeanObject>> allBeans) {
+                static ClusterBean of(Map<Integer, ? extends Collection<? extends HasBeanObject>> allBeans) {

Contributor Author

chia7712 Jan 23, 2023

方便讓我們用不同集合建立ClusterBean


          tweak

a0f0067

chia7712 merged commit be296c9 into opensource4you:main

chia7712 deleted the make_all_brokers_has_cost branch

March 27, 2023 13:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet