-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of ClusterInfoBuilder
#1165
Merged
garyparrot
merged 7 commits into
opensource4you:main
from
garyparrot:clusterinfo-alteration
Nov 28, 2022
Merged
Implementation of ClusterInfoBuilder
#1165
garyparrot
merged 7 commits into
opensource4you:main
from
garyparrot:clusterinfo-alteration
Nov 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A series of function for changing the cluster info
測試之後會補上 |
ClusterInfoAlteration
ClusterInfoAlteration
chia7712
reviewed
Nov 24, 2022
common/src/main/java/org/astraea/common/admin/ClusterInfoAlteration.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoAlteration.java
Outdated
Show resolved
Hide resolved
ClusterInfoAlteration
ClusterInfoBuilder
chia7712
reviewed
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garyparrot 這是一個很有用的工具,不過如同前面很多次討論工具時的話題,要避免程式碼寫到發散,也就是少了一個設計的”核心“,變成想到什麼就寫什麼,下面我留了幾個討論,麻煩看一下
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/admin/ClusterInfoBuilder.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1157
實作一些物件能夠方便我們從無生出一個
ClusterInfo
ClusterInfoBuilder
,可以對空或是給定的ClusterInfo
做出轉變。Demo
為避免 PR 臃腫,關於
ClusterLogAllocation
的整合會在其他 PR 完成。